Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(barman): add optional annotations to PVCs #691

Merged
merged 2 commits into from
May 25, 2022
Merged

feat(barman): add optional annotations to PVCs #691

merged 2 commits into from
May 25, 2022

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented May 25, 2022 •
edited
Loading

Description

Allow specifying annotations on both the backup and recovery PVC.

This can be used to set any annotations on the PVC (ie. a resource policy as described in #644

persistence:
  data:
    annotations:
      helm.sh/resource-policy: keep

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2022
@hairmare hairmare mentioned this pull request May 25, 2022
Closed
@hairmare hairmare marked this pull request as ready for review May 25, 2022 09:42
@hairmare hairmare requested review from a team and michaelimfeld as code owners May 25, 2022 09:42
@hairmare hairmare requested review from eyenx and vmaillot and removed request for a team May 25, 2022 09:42
@hairmare hairmare merged commit a9a6af8 into adfinis:main May 25, 2022
@hairmare hairmare deleted the feat/barman/pvc-annotations branch May 25, 2022 09:47
@eyenx eyenx mentioned this pull request Jun 3, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaillot vmaillot vmaillot approved these changes

@michaelimfeld michaelimfeld Awaiting requested review from michaelimfeld

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

barman: When uninstall barman helm chart the pvc should keep but not be deleted
2 participants
@hairmare @vmaillot