feat: Replace SystemStateReader.read() with lru_cache #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winged
requested changes
Apr 17, 2024
In preparation for LRU caching, don't make the reader store the variables itself. Instead, the functions return the read state directly. The now defunct read() function is removed separately
The FunctionCommand was required to reset the reader, which is not necessary anymore.
These provides are not necessary for dependecy resolving. But upcoming caching will reuse the provides and therefore require consistent use of it.
Melkor333
force-pushed
the
better-state-caching
branch
from
9a4806a
to
d9b587b
Compare
Add an LRU cache to the state_reader so state is only reread when an actual changing command has been executed. After command execution the cache of the relevant types is cleared.
Melkor333
force-pushed
the
better-state-caching
branch
from
d9b587b
to
2542fdb
Compare
|
BTW. I did a very quick check to see if the tests are faster.... But the tests are still requiring internet (the ubuntu keyservers AFAIU) and I only let it run a single time. But if the tests themselves only take half the time, I can imagine a great speed up for complex setups. We'll see... |
winged
requested changes
Apr 22, 2024
Mirrors are updated ad-hoc. No dependency-management is required. Therefore no Command is generated and the `mirror` dependency-type doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the very time intensive
SystemStateReader.read()function and use functions that directly return the variables.Solve the caching Problem with
lru_cache, which is cleared with...clear_cache()whenever a respectiveCommandis run.Since the
Commandalready has aprovidesfunction withknown_dependency_typeswhich pretty much exactly resembles the state variables that should be cached, I wrote a smallCommand.clear_caches()function which clears caches whenever a Command has been run.I added some
providesdefinitions so that it should work consistently with the cache resetting.I also split it up into various "easier to understand" feature-separate commits - they should even run through the tests individually :)
You can also read the commit notes to follow my thought process.
FWIW I don't really understand the tests all too well and am not 100% sure I didn't accidentally "break" a test. I'm also not sure if more tests would be necessary to properly test the caching... But it looks very much like my changes are correct.