fix: get state_reader via function #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhizoome
force-pushed
the
jlf/fix-get-state_reader-via-function
branch
from
3df3de7
to
da7c374
Compare
winged
approved these changes
Mar 14, 2024
pyaptly/state_reader.py
Outdated
| _state_reader: SystemStateReader | None = None | ||
|
|
||
|
|
||
| def get_state_reader(): |
There was a problem hiding this comment.
We could probably do without the get_ prefix, I think it's just as readable / understandable if the function's just called state_reader().
Merged
this is not much better, but the function name documents what is happening
rhizoome
force-pushed
the
jlf/fix-get-state_reader-via-function
branch
from
da7c374
to
5ecb270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not much better, but the function name documents what is happening