-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: frontend #483
Open
c0rydoras
wants to merge
128
commits into
adfinis:main
Choose a base branch
from
c0rydoras:refactor/frontend/css
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: frontend #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
c0rydoras
commented
Oct 2, 2024
•
edited
Loading
edited
- get rid of adcssy.scss (and all other scss)
- use adfinis ci (colors)
- currently toggle-able via ctrl+.
- support for dark mode
- currently toggle-able via ctrl+,
- fix some bugs
- comments can only be deleted if they exist
- the save button is disabled if the report is invalid
- some visual bugs
c0rydoras
force-pushed
the
refactor/frontend/css
branch
3 times, most recently
from
October 2, 2024 08:34
3d77b08
to
ab8126e
Compare
This was
linked to
issues
Oct 2, 2024
c0rydoras
force-pushed
the
refactor/frontend/css
branch
4 times, most recently
from
October 2, 2024 10:10
e5540ba
to
5f4bbee
Compare
Just as a note for later: The same needs to be done for the customer-center |
c0rydoras
force-pushed
the
refactor/frontend/css
branch
10 times, most recently
from
October 4, 2024 12:18
debab36
to
37abeff
Compare
c0rydoras
force-pushed
the
refactor/frontend/css
branch
8 times, most recently
from
October 21, 2024 07:31
e5bd6e1
to
dc1cf6b
Compare
c0rydoras
force-pushed
the
refactor/frontend/css
branch
2 times, most recently
from
October 28, 2024 13:35
aeac3af
to
76dc6c8
Compare
this introduces the color `foreground-accent` which is meant for highlighting things e.g. in the analysis if you can edit something also used for highlighting what tab in a NavTabs nav is active and in other places as well
if no color-scheme is saved in localStorage it defaults to the one the user prefers (via media query) if no theme is saved in localStorage it defaults to old
c0rydoras
force-pushed
the
refactor/frontend/css
branch
2 times, most recently
from
November 25, 2024 15:06
18b0c1f
to
45e2baf
Compare
c0rydoras
force-pushed
the
refactor/frontend/css
branch
from
November 25, 2024 15:12
bca3427
to
cbe1bbc
Compare
c0rydoras
force-pushed
the
refactor/frontend/css
branch
from
November 25, 2024 15:53
dcd7c7f
to
9dbc528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.