Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge prebid/Prebid into adform/Prebid #10

Merged
merged 75 commits into from
Jun 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
b58c9db
Added an editorconfig file to match jshint and jssrc files. (#1147)
SPGWhistler May 2, 2017
441455d
Sonobi Adapter - Enable size overrides (#1141)
Studnicky May 2, 2017
4be50ea
AdSupply adapter (#1162)
msadsupply May 2, 2017
a374e81
Bidfluence CDN endpoint URL update (#1163)
francescocristallo May 2, 2017
2652fc0
added audit beacon to detect misuse of this bidder. Detects auctions…
jstocker76 May 2, 2017
7fde081
remove old adloader#trackPixel (#1159)
snapwich May 2, 2017
c17c483
Pubgears Header Bidding Adapter (#953)
Walexander May 2, 2017
4470c08
Prebid Server to Server (#1165)
jaiminpanchal27 May 2, 2017
22b9422
AOL Adapter - ONE Mobile endpoint implemented. (#1115)
May 2, 2017
90e67f0
Quantcast adaptor (#1063)
ShreeniwasIyer May 2, 2017
2b3161f
Audience Network: bid when at least one valid slot size (#1148)
lovell May 2, 2017
8fbb1e2
Widespace adapter validate size fix (#1140)
jonasmattsson1 May 2, 2017
0956c74
Yieldbot adapter - multiple requestBids per pageview (#1146)
elljoh May 2, 2017
f97cccc
Prebid 0.23.0 Release
May 2, 2017
d6fd130
pre-release version bump
May 2, 2017
41526ba
Bugfix: internal bids requested overwritten (#1173)
May 3, 2017
40a8848
Improve footer styling (#1171)
matthewlane May 3, 2017
7fba6dd
fix size mapping for s2s (#1175)
May 4, 2017
73dfa73
add lodash as dependency (#1174)
snapwich May 4, 2017
efed21e
Bugfix/encoding url (#1178)
May 4, 2017
337328f
check array length when mapping sizes (#1180)
May 4, 2017
38d6d3a
Sharethrough: Change to using a closure for the callback from ajax to…
rizhang May 5, 2017
f62114d
change s2s adapter to filter out units with empty sizes array (#1179)
May 5, 2017
0e70c38
Clear cookie sync to prevent multiple calls (#1181)
May 5, 2017
8bb3e7f
Add trafficSourceCode + test (#1184)
May 8, 2017
32053f7
Prebid 0.23.1 Release
May 8, 2017
3252cb4
pre release version bump
May 9, 2017
0eba2bc
inclusion of popular Nordic ad sizes to default size list (#1168)
May 10, 2017
0b9dc7b
Add PubWise Analytics (#1151)
GLStephen May 15, 2017
5e7ef8f
add new rp_secure param to rubicon adapter (#1190)
snapwich May 15, 2017
2485377
Add type conversion into PrebidServer to handle inconsistent types. (…
May 16, 2017
ecc4f33
Bug fix: bids served by secure creatives does not get pushed into _wi…
canyousayyes May 16, 2017
ed24249
Add dynamic bidfloor parameter to Smart Adserver Adapter (#1194)
May 17, 2017
0799a64
Upgrade linters to ESLint with stricter code style (#1111)
matthewlane May 17, 2017
4b938b2
Add Support for DigiTrust in Rubicon Adapter (#1201)
grevory May 17, 2017
ca4c66a
HIRO Media: Remove batching mechanism and use AJAX instead of JSONP (…
ronenst May 17, 2017
a12fd8a
Rename secureCreatives file and lint (#1203)
grevory May 18, 2017
d630e3b
Common user-sync (#1144)
ckbo3hrk May 18, 2017
df1d0f7
updated tag (#1212)
jaiminpanchal27 May 18, 2017
9c9bf4a
Allowed setTargetingForGPTAsync() to target specific ad unit codes. (…
schiem May 18, 2017
18955eb
Fixes #1114 possible xss issue (#1186)
May 18, 2017
ae3deb6
Improvement/prebid iframes amp pages (#1119)
May 18, 2017
1803b5a
Updated documentaion (#1160)
dbemiller May 18, 2017
29a521e
Improvement/alias queue (#1156)
dbemiller May 18, 2017
694dfba
Add native support (#1072)
matthewlane May 18, 2017
223b969
Improvement/timeout xhr (#1172)
May 18, 2017
baff871
When prebid server issues a no-bid response, call addBidResponse for …
dmitriyshashkin May 19, 2017
4c2f3b4
Thoughtleadr adapter - fix postMessage (#1207)
ilya-pirogov May 19, 2017
3f9ac58
Beachfront adapter - add ad unit size (#1183)
bfmdeploy May 19, 2017
6a8f481
Probed 0.24.0 Release
jaiminpanchal27 May 19, 2017
472a8c7
Increment pre version
jaiminpanchal27 May 19, 2017
b97baca
Map sponsor request param to endpoint param (#1219)
matthewlane May 24, 2017
a4d5160
Bugfix/target filtering api fix (#1220)
May 25, 2017
ea7b5fa
Audience Network: separate size from format (#1218)
lovell May 25, 2017
fb14458
tests: drop ie9 browserstack test
May 25, 2017
a2fb6c8
Prebid 0.24.1 Release
May 25, 2017
5170880
pre-release version bump
May 25, 2017
9b66380
Missing 250x250 ad size (#1225)
benjaminclot May 26, 2017
de09a97
Adding deal id to bid response (#1252)
jaiminpanchal27 May 31, 2017
d4748d0
admixer adapter: add "video" mediaType support (#1200)
Galphimbl Jun 5, 2017
6b36d64
create adapter adyoulike (#1155)
jbAdyoulike Jun 5, 2017
cf76e85
Fixes #998 Allow keyvalues, gender and age to be passed in PubMatic (…
ptomasroos Jun 5, 2017
ece853a
remove superfluous parameter from openx adapter (#1237)
kkharma Jun 5, 2017
fd7ae19
Fixed syntax error in iframe content template (#1272)
jmanwaring Jun 7, 2017
53abddd
Fixed a bug in the gulpfile which caused bad /dev/ rebuilds when watc…
dbemiller Jun 7, 2017
78c1dc5
the prebid global variable does not have to be 'pbjs'. (#1275)
joyofdata Jun 7, 2017
3d174d1
Adding Video Support for Conversant Adapter (#1153)
trex-conversant Jun 7, 2017
66089e3
Prevent 'about:' protocol in _publisherTagUrl (#1170)
tomraa Jun 7, 2017
adf68ae
Rubicon Adapter - Adding 320x150 (#1279)
levjad Jun 8, 2017
afd7da6
Add drop pixels once feature to AOL Adapter (#1224)
vzhukovsky Jun 9, 2017
68a0f9c
use request bidder code as default bidderCode for createBid (#1235)
kitwestneat Jun 9, 2017
d019890
Trion adapter (#1254)
grohm33 Jun 9, 2017
f17ec54
Getting DigiTrustID in GumGum adapter (#1256)
bruscantini Jun 9, 2017
b680317
Integration test page for adapters (#1182)
dbemiller Jun 9, 2017
e456fcf
Pass through transactionId and set fd=1 (#1259)
Pupis Jun 12, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
root = true

[*]
end_of_line = lf
insert_final_newline = true

[*.js]
charset = utf-8
indent_style = space
indent_size = 2
trim_trailing_whitespace = true
42 changes: 42 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
{
"env": {
"browser": true,
"commonjs": true
},
"extends": "standard",
"globals": {
"$$PREBID_GLOBAL$$": false
},
"parserOptions": {
"sourceType": "module"
},
"rules": {
"comma-dangle": "off",
"semi": "off",
"space-before-function-paren": "off",

// Exceptions below this line are temporary, so that eslint can be added into the CI process.
// Violations of these styles should be fixed, and the exceptions removed over time.
//
// See Issue #1111.
"brace-style": "off",
"camelcase": "off",
"eqeqeq": "off",
"import/first": "off",
"no-control-regex": "off",
"no-mixed-operators": "off",
"no-multiple-empty-lines": "off",
"no-redeclare": "off",
"no-return-assign": "off",
"no-throw-literal": "off",
"no-undef": "off",
"no-unused-vars": "off",
"no-use-before-define": "off",
"no-useless-call": "off",
"no-useless-escape": "off",
"one-var": "off",
"standard/no-callback-literal": "off",
"standard/object-curly-even-spacing": "off",
"valid-typeof": "off"
}
}
3 changes: 3 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ Thank you for your pull request. Please make sure this PR is scoped to one chang
}
}
```

Be sure to test the integration with your adserver using the [Hello World](/integrationExamples/gpt/hello_world.html) sample page.

- contact email of the adapter’s maintainer
- [ ] official adapter submission

Expand Down
11 changes: 0 additions & 11 deletions .jscsrc

This file was deleted.

39 changes: 0 additions & 39 deletions .jshintrc

This file was deleted.

70 changes: 29 additions & 41 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,42 @@
# Contributing to Prebid.js
Contributions are always welcome. To contribute, [fork](https://help.github.com/articles/fork-a-repo/) Prebid.js, commit your changes, and [open a pull request](https://help.github.com/articles/using-pull-requests/).
Contributions are always welcome. To contribute, [fork](https://help.github.com/articles/fork-a-repo/) Prebid.js,
commit your changes, and [open a pull request](https://help.github.com/articles/using-pull-requests/) against the
master branch.

## Pull Requests
Please make sure that pull requests are scoped to one change, and that any added or changed code includes tests with greater than 80% code coverage. See [Testing Prebid.js](#testing-prebidjs) for help on writing tests.
Pull requests must have 80% code coverage before beign considered for merge.
Additional details about the process can be found [here](./pr_review.md).

## Issues
[prebid.org](http://prebid.org/) contains documentation that may help answer questions you have about using Prebid.js. If you can't find the answer there, try searching for a similar issue on the [issues page](https://github.com/prebid/Prebid.js/issues). If you don't find an answer there, [open a new issue](https://github.com/prebid/Prebid.js/issues/new).
[prebid.org](http://prebid.org/) contains documentation that may help answer questions you have about using Prebid.js.
If you can't find the answer there, try searching for a similar issue on the [issues page](https://github.com/prebid/Prebid.js/issues).
If you don't find an answer there, [open a new issue](https://github.com/prebid/Prebid.js/issues/new).

## Documentation
If you have a documentation issue or pull request, please open a ticket or PR in the [documentation repository](https://github.com/prebid/prebid.github.io).

## Testing Prebid.js
Pull requests to the Prebid.js library will need to include tests with greater than 80% code coverage for any changed/added code before they can be merged into master.
## Writing Tests

This section describes how to test code in the Prebid.js repository to help prepare your pull request.
Prebid uses [Mocha](http://mochajs.org/) and [Chai](http://chaijs.com/) for unit tests. [Sinon](http://sinonjs.org/)
provides mocks, stubs, and spies. [Karma](https://karma-runner.github.io/1.0/index.html) runs the tests and generates
code coverage reports at `build/coverage/lcov/lcov-report/index.html`.

### Writing tests
Tests are stored in the [test/spec](test/spec) directory. Tests for Adapters are located in [test/spec/adapters](test/spec/adapters).
They can be run with the following commands:

- `gulp test` - run the test suite once (`npm test` is aliased to call `gulp test`)
- `gulp serve` - run the test suite once, but re-run it whenever a file in the `src` or `test` directory is modified

Before a Pull Request will be considered for merge:

- All new and existing tests must pass
- Added or modified code must have greater than 80% coverage

If you are submitting an adapter, you can also use the [Hello World](integrationExamples/gpt/hello_world.html) example page to test integration with your server.

### Test Guidelines
When you are adding code to Prebid.js, or modifying code that isn't covered by an existing test, test the code according to these guidelines:

- If the module you are working on is already partially tested by a file within the `test` directory, add tests to that file
- If the module you are working on is already partially tested by a file within the `test/spec` directory, add tests to that file
- If the module does not have any tests, create a new test file
- Group tests in a `describe` block
- Test individual units of code within an `it` block
Expand All @@ -36,31 +54,8 @@ When you are adding code to Prebid.js, or modifying code that isn't covered by a
- If you need to check `adloader.loadScript` in a test, use a `stub` rather than a `spy`. `spy`s trigger a network call which can result in a `script error` and cause unrelated unit tests to fail. `stub`s will let you gather information about the `adloader.loadScript` call without affecting external resources
- When writing tests you may use ES2015 syntax if desired

### Running tests
After checking out the Prebid.js repository and installing dev dependencies with `npm install`, use the following commands to run tests as you are working on code:

- `gulp test` will run the test suite once (`npm test` is aliased to call `gulp test`)
- `gulp serve` will run tests once and stay open, re-running tests whenever a file in the `src` or `test` directory is modified

### Checking results and code coverage
Check the test results using these guidelines:

- Look at the total number of tests run, passed, and failed in the shell window.
- If all tests are passing, great.
- Otherwise look for errors printed in the console for a description of the failing test.
- You may need to iterate on your code or tests until all tests are passing.
- Make sure existing tests still pass.
- There is a table below the testing report that shows code coverage percentage, for each file under the `src` directory.
- Each time you run tests, a code coverage report is generated in `build/coverage/lcov/lcov-report/index.html`.
- This is a static HTML page that you can load in your browser.
- On that page, navigate to the file you are testing to see which lines are being tested.
- Red indicates that a line isn't covered by a test.
- Gray indicates a line that doesn't need coverage, such as a comment or blank line.
- Green indicates a line that is covered by tests.
- The code you have added or modified must have greater than 80% coverage to be accepted.

### Examples
Prebid.js already has lots of tests. Read them to see how Prebid.js is tested, and for inspiration:
### Test Examples
Prebid.js already has many tests. Read them to see how Prebid.js is tested, and for inspiration:

- Look in `test/spec` and its subdirectories
- Tests for bidder adaptors are located in `test/spec/adapters`
Expand All @@ -82,10 +77,3 @@ describe('<Adapter>', () => {
// Add other `describe` or `it` blocks as necessary
});
```

### Resources
The Prebid.js testing stack contains some of the following tools. It may be helpful to consult their documentation during the testing process.

- [Mocha - test framework](http://mochajs.org/)
- [Chai - BDD/TDD assertion library](http://chaijs.com/)
- [Sinon - spy, stub, and mock library](http://sinonjs.org/)
16 changes: 10 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@

> A free and open source library for publishers to quickly implement header bidding.

This README is for developers who want to contribute to Prebid.js. For user-facing documentation, see [Prebid.org](http://prebid.org).
This README is for developers who want to contribute to Prebid.js.
Additional documentation can be found at [the Prebid homepage](http://prebid.org).
Working examples can be found in [the developer docs](http://prebid.org/dev-docs/getting-started.html).

**Table of Contents**

Expand All @@ -26,13 +28,13 @@ This README is for developers who want to contribute to Prebid.js. For user-fac
$ cd Prebid.js
$ yarn install

Prebid now supports the `yarn` npm client. This is an alternative to using `npm` for package management, though `npm` will continue to work as before.
Prebid also supports the `yarn` npm client. This is an alternative to using `npm` for package management, though `npm` will continue to work as before.

For more info about yarn see https://yarnpkg.com
For more info, see [the Yarn documentation](https://yarnpkg.com).

<a name="Build"></a>

## Build for Dev
## Build for Development

To build the project on your local machine, run:

Expand Down Expand Up @@ -148,6 +150,8 @@ A watch is also in place that will run continuous tests in the terminal as you e

Many SSPs, bidders, and publishers have contributed to this project. [60+ Bidders](https://github.com/prebid/Prebid.js/tree/master/src/adapters) are supported by Prebid.js.

For guidelines, see [Contributing](./CONTRIBUTING.md).

Our PR review process can be found [here](https://github.com/prebid/Prebid.js/tree/master/pr_review.md).

### Add a Bidder Adapter
Expand All @@ -158,9 +162,9 @@ Please **do NOT load Prebid.js inside your adapter**. If you do this, we will re

### Code Quality

Code quality is defined by `.jscs` and `.jshint` files and errors are reported in the terminal.
Code quality is defined by `.eslintrc` and errors are reported in the terminal.

If you are contributing code, you should configure your editor with the provided `.jscs` and `.jshint` settings.
If you are contributing code, you should [configure your editor](http://eslint.org/docs/user-guide/integrations#editors) with the provided `.eslintrc` settings.

### Unit Testing with Karma

Expand Down
20 changes: 18 additions & 2 deletions adapters.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"adform",
"adkernel",
"admedia",
"adyoulike",
"bidfluence",
"vertamedia",
"aol",
Expand All @@ -30,8 +31,10 @@
"openx",
"piximedia",
"pubmatic",
"pubgears",
"pulsepoint",
"pulsepointLite",
"quantcast",
"rhythmone",
"rubicon",
"smartyads",
Expand Down Expand Up @@ -64,6 +67,8 @@
"atomx",
"tapsense",
"trion",
"prebidServer",
"adsupply",
{
"appnexus": {
"alias": "brealtime"
Expand All @@ -86,9 +91,10 @@
},
{
"appnexusAst": {
"supportedMediaTypes": ["video"]
"supportedMediaTypes": ["video", "native"]
}
}, {
},
{
"vertamedia": {
"supportedMediaTypes": ["video"]
}
Expand Down Expand Up @@ -138,5 +144,15 @@
"rhythmone": {
"supportedMediaTypes": ["video"]
}
},
{
"admixer": {
"supportedMediaTypes": ["video"]
}
},
{
"conversant": {
"supportedMediaTypes": ["video"]
}
}
]
2 changes: 1 addition & 1 deletion analytics.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
[]
[]
8 changes: 0 additions & 8 deletions browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,6 @@
"device": null,
"os": "Windows"
},
"bs_ie_9_windows_7": {
"base": "BrowserStack",
"os_version": "7",
"browser": "ie",
"browser_version": "9.0",
"device": null,
"os": "Windows"
},
"bs_firefox_46_windows_7": {
"base": "BrowserStack",
"os_version": "7",
Expand Down
Loading