Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order of arguments when using application #95

Closed
tbreuss opened this issue Jan 22, 2024 · 4 comments · Fixed by #97
Closed

Wrong order of arguments when using application #95

tbreuss opened this issue Jan 22, 2024 · 4 comments · Fixed by #97

Comments

@tbreuss
Copy link

tbreuss commented Jan 22, 2024

I noticed that when using the cli application and adding two or more arguments for a command, the ordering of the arguments in the help may differ from the setup.

This is what I configured for a certain command:

Bildschirmfoto 2024-01-22 um 14 44 13

And this is what the help for the given command outputs:

Bildschirmfoto 2024-01-22 um 14 44 52

It seems like the output of the help command orders the arguments by name ascending.

@adhocore
Copy link
Owner

oh that if true, seems like visual issue only. could you pls check if the functioning is as expected even though help output is different. thank you

@tbreuss
Copy link
Author

tbreuss commented Jan 22, 2024

oh that if true, seems like visual issue only. could you pls check if the functioning is as expected even though help output is different. thank you

It's only visual, not a big issue, but quite confusing if the order is mixed up and you trust the help.

I'm not sitting in front of the computer right now, but the problem could be found here:
https://github.com/adhocore/php-cli/blob/main/src/Helper/OutputHelper.php#L200

@adhocore
Copy link
Owner

thanks for feedback, fixed in #97

adhocore added a commit that referenced this issue Jan 22, 2024
fix(helper): arguments help output must not be sorted #95
@tbreuss
Copy link
Author

tbreuss commented Jan 23, 2024

thanks for feedback, fixed in #97

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants