Allow for custom default command execution without arguments #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for PR. @dimtrovich could you check it too? |
|
I've done a few tests and it's fine @kodie please can you add a test (https://github.com/adhocore/php-cli/blob/main/tests/ApplicationTest.php) |
|
@dimtrovich Done! |
dimtrovich
approved these changes
Nov 19, 2024
|
thank you both 🎉 will release this tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you set a custom default command and then try to run it without passing it any arguments, the help screen will be displayed just like it would have if we never set a custom default command.
This small PR makes it so that your default command can be ran without passing it any arguments.