Production HSES import fix #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First production deploy
Add Next Steps Page
New Relic deployment records & Production TTA Plan import
Add sorting to My Alerts
|
This has been pushed to production as a hotfix. |
rahearn
commented
Mar 15, 2021
| })); | ||
| const grantsForDb = grant.grant_awards.grant_award.map((g) => { | ||
| let { grant_start_date: startDate, grant_end_date: endDate } = g; | ||
| if (typeof startDate === 'object') { startDate = null; } |
There was a problem hiding this comment.
nil dates in the xml end up being { "xsi:nil": true } here
dcmcand
approved these changes
Mar 15, 2021
|
jasalisbury
approved these changes
Mar 15, 2021
correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
nilgrant start and end datesHow to test
Production data imports successfully. Ryan tested this on GFE with a production dataset.
Issue(s)
Checklist