forked from HHS/Head-Start-TTADP
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTAHUB-278] grantee search page #403
Merged
thewatermethod
merged 46 commits into
TTAHUB-298/create-grantee-record-page
from
TTAHUB-278
Oct 5, 2021
Merged
[TTAHUB-278] grantee search page #403
thewatermethod
merged 46 commits into
TTAHUB-298/create-grantee-record-page
from
TTAHUB-278
Oct 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
AdamAdHocTeam,
jasalisbury,
kryswisnaskas and
matthinz
August 25, 2021 20:55
jasalisbury
approved these changes
Aug 26, 2021
thewatermethod
requested review from
jasalisbury
and removed request for
matthinz,
jasalisbury,
kryswisnaskas and
AdamAdHocTeam
September 22, 2021 14:59
thewatermethod
changed the title
[TTAHUB-278] add new page to search grantees records
[TTAHUB-278] grantee search page
Oct 5, 2021
thewatermethod
requested review from
jasalisbury,
AdamAdHocTeam and
kryswisnaskas
October 5, 2021 13:05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues I found so far.
- If 'All Regions' is selected nothing ever comes back from the search.
- If I have region 1 selected with search criteria. Then clear the search box and switch to a new region it seems to hang.
thewatermethod
changed the base branch from
main
to
TTAHUB-298/create-grantee-record-page
October 5, 2021 20:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add a new page (feature flagged for admins only right now) for grantee records. Right now, the page only has a heading, a search box, and a region selector.
How to test
When you are logged in as an admin, the site should have a "Grantees" link in the left side nav. The link should take you to /grantee-search. On that page, there should be a heading, a region selector, and a search form. The should appear functional but don't, as of yet, have any impact on the page itself.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy