Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-278] grantee search page #403

Merged
merged 46 commits into from
Oct 5, 2021

Conversation

thewatermethod
Copy link
Collaborator

Description of change

Add a new page (feature flagged for admins only right now) for grantee records. Right now, the page only has a heading, a search box, and a region selector.

How to test

When you are logged in as an admin, the site should have a "Grantees" link in the left side nav. The link should take you to /grantee-search. On that page, there should be a heading, a region selector, and a search form. The should appear functional but don't, as of yet, have any impact on the page itself.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review August 25, 2021 20:55
@thewatermethod thewatermethod changed the title [TTAHUB-278] add new page to search grantees records [TTAHUB-278] grantee search page Oct 5, 2021
@thewatermethod thewatermethod marked this pull request as draft October 5, 2021 13:05
Copy link

@AdamAdHocTeam AdamAdHocTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues I found so far.

  1. If 'All Regions' is selected nothing ever comes back from the search.
  2. If I have region 1 selected with search criteria. Then clear the search box and switch to a new region it seems to hang.

@thewatermethod thewatermethod changed the base branch from main to TTAHUB-298/create-grantee-record-page October 5, 2021 20:15
@thewatermethod thewatermethod merged commit 2e92a8c into TTAHUB-298/create-grantee-record-page Oct 5, 2021
@thewatermethod thewatermethod deleted the TTAHUB-278 branch October 5, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants