Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTAHUB-323] resolve bug with displaying dates on total hrs and grantee graph #412

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

thewatermethod
Copy link
Collaborator

Description of change

Dates (when the range stretches over more than one month) are labelled incorrectly in the accessible data table. Now the dates are displayed correctly.

How to test

View the data table on the total hours and grantee graph, selecting a date range that incorporates less than 31 days and two different months. (for example, 7/15/21-8/03/21)

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • [n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review September 7, 2021 20:23
@jasalisbury
Copy link

Screenshot from 2021-09-07 16-53-19
I'm still seeing some goofiness with the graph. It appears days with zero reports are being skipped. Not only does the end date not go to the 20 I'm missing an entry for Feb 27, 28 and March 6, 7 and 11-14.

@thewatermethod
Copy link
Collaborator Author

Yeah - that's working as intended, as far as I know. The Jira only referenced the mislabeled data table.

Copy link

@jasalisbury jasalisbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - that's working as intended, as far as I know. The Jira only referenced the mislabeled data table.

My bad, should have paid more attention to the ticket! This looks good to me!

@thewatermethod thewatermethod merged commit c433127 into main Sep 8, 2021
@thewatermethod thewatermethod deleted the TTAHUB-323 branch September 8, 2021 14:12
thewatermethod added a commit that referenced this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants