forked from HHS/Head-Start-TTADP
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Elasticsearch integration #421
Open
matthinz
wants to merge
16
commits into
main
Choose a base branch
from
elasticsearch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a single ES node at http://elasticsearch:9200
- Send ActivityReports to ES - Beginnings of unit / integration test infra - Still many things left to do
Add ES inside application boundary
Was getting quite large
This tells the ES client where to talk to ES.
Not all tests complete, but the basics are there.
- Start laying out mappings for ActivityRecord - Introduce pipeline for AR's (with HTML stripping) - Likely break a number of things ahead of demo Tuesday
Once we've pulled text content out of files, remove the base64-encoded version. This will hopefully help keep our indices smaller. The original files are still in S3 if they are needed.
Provide some detail on how ES works and how it is integrated.
(Sandbox only, for now.)
…into elasticsearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR includes the beginning of Elasticsearch integration for the application. It includes Elasticsearch running locally (in Docker Compose). Included in the docs is a high-level overview of what Elasticsearch is and how this integration is managed.
These are the steps required to get this implementation ready and get to a place where we can start building indices of Activity Reports and their attachments in production:
TODO
unit testsHow to test
After you bring up the local development environment, create Activity Reports and upload attachments as usual. I have been using Elasticvue to monitor the kinds of data being written to search indices. You can bring it up in Docker using the following command:
Then navigate to http://localhost:8081 in your browser.
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy