migration to spark 3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcorreia
reviewed
May 4, 2021
README.md
Outdated
| @@ -48,6 +48,7 @@ M3D Engine supports: | |||
|
|
|||
| * Loading structured and semi-structured data in Full mode | |||
| * Loading structured and semi-structured data in Append mode | |||
| * Loading structured and semi-structured data in Delta mode | |||
There was a problem hiding this comment.
We can remove this row, as the row bellow describes the two options
jmcorreia
reviewed
May 4, 2021
build.sbt
Outdated
| @@ -3,17 +3,18 @@ import sbt.ExclusionRule | |||
| name := "m3d-engine" | |||
| version := "1.0" | |||
jmcorreia
reviewed
May 4, 2021
| @@ -0,0 +1,23 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
I don't remember any particular thing for now, but would it make sense to add a few more notes to the changelog as this 6.0.0 brought other improvements and fixes? Not only the migration, but also other things that we did not bring to the OS in the past? Maybe go through out changelog and add the most important things here
There was a problem hiding this comment.
Also, can we create a release and/or tag to start separating this for people to easily see and use particular versions?
jmcorreia
reviewed
May 4, 2021
| @@ -50,7 +50,7 @@ trait AlgorithmTemplateConfiguration | |||
| CatalogTableManager(targetTable, spark).getSchemaSafely(dfs) | |||
|
|
|||
| override protected val readers: Vector[InputReader.TableReader] = Vector( | |||
| // Obtaining a reader for the algorithm | |||
| // Obtaining a reader for the algorithm. | |||
jmcorreia
approved these changes
May 4, 2021
jmcorreia
reviewed
May 4, 2021
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| M3D Engine | |||
| ======= | |||
|
|
|||
|  | |||
|  | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.