Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(statuspage): Add link to statuspage #17

Merged
merged 1 commit into from
Oct 20, 2021
Merged

feat(statuspage): Add link to statuspage #17

merged 1 commit into from
Oct 20, 2021

Conversation

mwadm
Copy link
Contributor

@mwadm mwadm commented Oct 20, 2021

Add statuspage link for user to get updated information about the maintenance.

@adinhodovic
Copy link
Owner

Thanks @mwadm, change is welcome! Could you add the variable to variables.tf, so it is configurable. Is it also possible to make it opt-in? Smaller orgs probably don't have a status page.

@mwadm
Copy link
Contributor Author

mwadm commented Oct 20, 2021

Hi adinhodovic, thanks for your work. I'm gonna make it opt-in.

@mwadm
Copy link
Contributor Author

mwadm commented Oct 20, 2021

don't merge for now i need to do some more test

@mwadm
Copy link
Contributor Author

mwadm commented Oct 20, 2021

All good for me, i have to use null as a string to work with template. By default statuspage_url is at null and will not be displayed.

@adinhodovic adinhodovic self-requested a review October 20, 2021 15:24
@adinhodovic adinhodovic merged commit 74db6b7 into adinhodovic:master Oct 20, 2021
@adinhodovic
Copy link
Owner

Thanks a lot, works great!

@mwadm
Copy link
Contributor Author

mwadm commented Oct 20, 2021

Can you make a tag for this new version please ? Thank you very much

@adinhodovic
Copy link
Owner

Can you make a tag for this new version please ? Thank you very much

Updated and released a Git tag for v0.5.0. The module is updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants