Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thumbnailUrl with logo #1488

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Replace thumbnailUrl with logo #1488

merged 2 commits into from
Nov 8, 2024

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Apr 11, 2024 •
edited
Loading

thumbnailUrl is not part of Organization: https://schema.org/Organization

What does this PR change? What problem does it solve?

The default publisher type, as defined by this theme, is "Organization". However, based on its definition at https://schema.org/Organization, thumbnail is not part of "Organization".

This PR addresses this issue by replacing thumbnailUrl with logo.

Alternatively, if the maintainer feels like it, we can use image as well. The advantage of image is that it is also defined as part of Person: https://schema.org/Person

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

xuhdev added a commit to 8hobbies/KamiMod that referenced this pull request Jun 3, 2024
@xuhdev
Add features
f3f2276 
- adityatelange/hugo-PaperMod#1049
- adityatelange/hugo-PaperMod#1337
- adityatelange/hugo-PaperMod#1488
- adityatelange/hugo-PaperMod#1494
- adityatelange/hugo-PaperMod#1533
@adityatelange adityatelange merged commit 0234865 into adityatelange:master Nov 8, 2024
1 check passed
@xuhdev xuhdev deleted the schema branch November 8, 2024 20:04
hankmor pushed a commit to hankmor/hugo-PaperMod that referenced this pull request Nov 16, 2024
@xuhdev
Replace thumbnailUrl with logo for json schema (adityatelange#1488)
095a64c 
thumbnailUrl is not part of Organization: https://schema.org/Organization
nsrahmad pushed a commit to nsrahmad/hugo-PaperMod that referenced this pull request Dec 7, 2024
@xuhdev @nsrahmad
Replace thumbnailUrl with logo for json schema (adityatelange#1488)
e747698 
thumbnailUrl is not part of Organization: https://schema.org/Organization
popolin7991 pushed a commit to popolin7991/hugo-PaperMod that referenced this pull request Dec 15, 2024
@xuhdev @popolin7991
Replace thumbnailUrl with logo for json schema (adityatelange#1488)
ae806fb 
thumbnailUrl is not part of Organization: https://schema.org/Organization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuhdev @adityatelange