Minor spelling and label fixes #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- md-entity template array-table title was changed to foreign key - fixed integration test to reflect changes Resolves adiwg#278
- new label for entity attribute is "attribute name" - new label for domain item is "domain item name"
|
Looks good. Ready to merge? |
|
Yes it is ready to go
…On Wed, Jan 15, 2020 at 1:38 PM Josh Bradley ***@***.***> wrote:
Looks good. Ready to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#371?email_source=notifications&email_token=AFZHACS5JI2VMGJOETDY5OLQ55J3FA5CNFSM4KFSK2X2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBKXFA#issuecomment-574794644>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZHACXJF7WH2XXJGAQTOODQ55J3FANCNFSM4KFSK2XQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "attribute" table name to "attribute name" in "dictionary.show.edit.entity" route
app/pods/components/object/md-entity/template.hbs
Changed "domain add item" table name to "domain item name" in "dictionary.show.edit.domain" route
app/pods/components/object/md-domain/template.hbs
Changed "entity keys" table name for foreign keys from "foreign key attribute" to "foreign key" in the
app/pods/components/object/md-entity/template.hbs
Resolves #276
Resolves #278
Resolves #273