Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions Trigger #60

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented May 22, 2024

Removing the requirement that the action only run when a PR is merged. This overcomplicates the process for using the token to write back to the gh-pages repository and is not needed when there are branch protections requiring that all merges must come from a PR.

Removing the requirement that the action only run when a PR is merged. This overcomplicates the process for using the token to write back to the gh-pages repository and is not needed when there are branch protections requiring that all merges must come from a PR.
@jwaspin jwaspin requested a review from hmaier-fws May 28, 2024 16:58
Copy link
Contributor

@hmaier-fws hmaier-fws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hmaier-fws hmaier-fws merged commit 2db9a59 into develop Jun 17, 2024
@jwaspin jwaspin deleted the fix/github-action-trigger branch June 17, 2024 18:32
hmaier-fws pushed a commit that referenced this pull request Dec 11, 2024
* GitHub Action to Deploy to GitHub Pages (and updates) (#58)

* Upgrade mdCodes and mdJson-schemas

* Increment Patch Version

* Update version

* add workflow

* Set version to 1.1.2

---------

Co-authored-by: Jonathan Oliveros <joliveros@xentity.com>

* Fix GitHub Actions Trigger (#60)

Removing the requirement that the action only run when a PR is merged. This overcomplicates the process for using the token to write back to the gh-pages repository and is not needed when there are branch protections requiring that all merges must come from a PR.

* Chore/update versions (#62)

* Fix GitHub Actions Trigger

Removing the requirement that the action only run when a PR is merged. This overcomplicates the process for using the token to write back to the gh-pages repository and is not needed when there are branch protections requiring that all merges must come from a PR.

* Bump mdcodes and mdjson-schemas to version 2.10.0 and 2.9.5 respectively

* Refactor GitHub Actions workflow to include build and deploy jobs, update action versions, and automate tagging and release creation.

* Bump version to 1.1.3 in package.json and package-lock.json

* Downgrade version to 1.1.1 in package.json

---------

Co-authored-by: Jonathan Oliveros <joliveros@xentity.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants