-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rearrange sac header writer #154
Open
casarotti
wants to merge
2
commits into
adjtomo:devel
Choose a base branch
from
casarotti:devel
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -207,6 +207,8 @@ def _append_sac_headers_trace(tr, event, inv): | |
"lcalda": 1, # 1 if DIST, AZ, BAZ, GCARC to be calc'd from metadata | ||
} | ||
|
||
sac_header["e"]=sac_header["e"]+sac_header["b"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it might be better to construct these explicitly before the dict construction, can we do something like: otime = event.preferred_origin().time
begin_time = tr.stats.starttime - otime
end_time = begin_time + (tr.stats.npts * tr.stats.delta)
sac_header = {
"iztype": 9, # Ref time equivalence, IB (9): Begin time
"b": begin_time,
"e": end_time,
"evla": event.preferred_origin().latitude,
"evlo": event.preferred_origin().longitude,
"stla": sta.latitude,
"stlo": sta.longitude,
"stel": sta.elevation / 1E3, # elevation in km
"kevnm": format_event_tag_legacy(event), # only take date code
"nzyear": otime.year,
"nzjday": otime.julday,
"nzhour": otime.hour,
"nzmin": otime.minute,
"nzsec": otime.second,
"nzmsec": int(f"{otime.microsecond:0>6}"[:3]), # micros->ms see #152
"dist": dist_km,
"az": az, # degrees
"baz": baz, # degrees
"gcarc": dist_deg, # degrees
"lpspol": 0, # 1 if left-hand polarity (usually no in passive seis)
"lcalda": 1, # 1 if DIST, AZ, BAZ, GCARC to be calc'd from metadata
} |
||
|
||
# Some Inventory objects will not go all the way to channel, only to station | ||
try: | ||
cha = sta[0] | ||
|
@@ -235,7 +237,7 @@ def _append_sac_headers_trace(tr, event, inv): | |
_warn_about.append(key) | ||
if _warn_about: | ||
logger.warning(f"no SAC header values found for: {_warn_about}") | ||
|
||
# Append SAC header and include back azimuth for rotation | ||
tr.stats.sac = sac_header | ||
tr.stats.back_azimuth = baz | ||
|
@@ -317,7 +319,7 @@ def _append_sac_headers_cartesian_trace(tr, event, rcv_x, rcv_y): | |
dist_deg = kilometer2degrees(dist_km) # spherical earth approximation | ||
azimuth = np.degrees(np.arctan2((rcv_x - src_x), (rcv_y - src_y))) % 360 | ||
backazimuth = (azimuth - 180) % 360 | ||
|
||
sac_header = { | ||
"iztype": 9, # Ref time equivalence, IB (9): Begin time | ||
"b": tr.stats.starttime - otime, # begin time | ||
|
@@ -341,9 +343,9 @@ def _append_sac_headers_cartesian_trace(tr, event, rcv_x, rcv_y): | |
"lpspol": 0, # 1 if left-hand polarity (usually no in passive seis) | ||
"lcalda": 1, # 1 if DIST, AZ, BAZ, GCARC to be calc'd from metadata | ||
} | ||
sac_header["e"]=sac_header["e"]+sac_header["b"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
|
||
tr.stats.sac = sac_header | ||
|
||
return tr | ||
|
||
|
||
|
@@ -382,7 +384,7 @@ def format_sac_header_w_taup_traveltimes(st, model="ak135", | |
for tr in st_out[:]: | ||
net_sta = ".".join(tr.get_id().split(".")[:2]) # NN.SSS | ||
|
||
# Missing SAC header values may cause certain or all stations to not | ||
# Missing SAC header values may cause certain or all stations to not | ||
# be present in the `phase_dict` | ||
if net_sta not in phase_dict: | ||
logger.warning(f"{tr.get_id()} not present in TauP arrivals, cant " | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this