You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
System modules derived from the Cluster class use an external run script to execute tasks on compute nodes. This run script is essentially a python script that loads functions from Pickle files and executes them. This allows tasks to be partitioned from a master job to each compute node.
Currently the run calls (located in the run() function) points to a symlink to a Python script, which was used to make things clearer. However when SeisFlows is installed via Pip, these symlinks are not carried through.
I see two ways to address this:
add a MANIFEST.in file to keep the symlinks
change the paths from 'run' to 'run_funcs.py' (which is carried through on pip installation)
If 2 is chosen, it might be beneficial to define the path to this script as a class variable once (in Cluster) rather than having it floating around in lots of different places. The same should be done for the submit workflow function:
System modules derived from the
Cluster
class use an external run script to execute tasks on compute nodes. This run script is essentially a python script that loads functions from Pickle files and executes them. This allows tasks to be partitioned from a master job to each compute node.seisflows/seisflows/system/cluster.py
Lines 166 to 172 in c01bc96
Currently the run calls (located in the run() function) points to a symlink to a Python script, which was used to make things clearer. However when SeisFlows is installed via Pip, these symlinks are not carried through.
I see two ways to address this:
If 2 is chosen, it might be beneficial to define the path to this script as a class variable once (in Cluster) rather than having it floating around in lots of different places. The same should be done for the submit workflow function:
seisflows/seisflows/system/cluster.py
Lines 120 to 125 in c01bc96
The text was updated successfully, but these errors were encountered: