Plot 2D improvement for models with complex topographies #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Bryant,
This patch adds
plot_2d_image
function and uses it inseisflows.tools.specfem.Model
It adds NaN values to the top edge of the model before interpolation to the regular grid. In order to fix the representation issue with complex topographies. I have also tested with flat topography, it didn't cause problems.
I couldn't it make it work tricontourf. Feel free to explore similar fix for it.
plot_2d_image
might be slower thanplot_2d_contour
since it uses imshow which requires a interpolated regular grid.Comparison image for the
simple_topography_and_also_a_simple_fluid_layer
specfem2D model.