Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smartling translations are completed for commit cbbcd7fb57679c3c953ca951fd90e96dcb492cd6 from main #1238

Merged

Conversation

smartling-github-connector[bot]
Copy link
Contributor

Please review this translation pull request. The relevant Smartling translation job is available here - https://dashboard.smartling.com/app/accounts/aaa8fc6f/account-jobs/224fc9b33:qejsrfcuuit6
Here is a link to the source commit which triggered translation - cbbcd7f

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 3:23pm

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1
Copy link
Collaborator

@bzavhorodskyi Are you able to request translation for this PR for all locales again? I don't know why, but strings are shown as "Awaiting Authorization" in Smartling but jobs were not created.

@bzavhorodskyi
Copy link
Collaborator

@bzavhorodskyi Are you able to request translation for this PR for all locales again? I don't know why, but strings are shown as "Awaiting Authorization" in Smartling but jobs were not created.

@tomokogoto1 https://dashboard.smartling.com/app/projects/224fc9b33/account-jobs/224fc9b33:qejsrfcuuit6 I`ve added these strings to the job

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1 New translations were added here

Copy link
Collaborator

@tomokogoto1 tomokogoto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev-docs-moemy7vyk-product-content.vercel.app/en/sdk/web

Translation is missing for all non-EN locales. Could you check why?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzavhorodskyi This page has missing translation (sub-heading and small texts)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzavhorodskyi This article contains missing translation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzavhorodskyi Same as other locales, some translation is missing

Copy link
Collaborator

@bzavhorodskyi bzavhorodskyi Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzavhorodskyi Same as other locales, some translation is missing

@tomokogoto1 For some reason, some words for this file were missed, I`ve added these strings to the job: https://dashboard.smartling.com/app/projects/224fc9b33/account-jobs/224fc9b33:qejsrfcuuit6

@tomokogoto1
Copy link
Collaborator

@bzavhorodskyi

Re:

https://dev-docs-879v3d9ub-product-content.vercel.app/ko/sdk/web
https://dev-docs-879v3d9ub-product-content.vercel.app/zh/sdk/web
https://dev-docs-879v3d9ub-product-content.vercel.app/ja/sdk/web

  1. Code looks different between the EN version and localized pages
  2. There is a strange text {/* prettier-ignore */} in localized pages

Screenshot 2025-01-16 at 14 10 35

@bzavhorodskyi
Copy link
Collaborator

@tomokogoto1
Copy link
Collaborator

Thank you for fixing: #1238 (comment)

Looks good!

@bzavhorodskyi bzavhorodskyi merged commit 58ea981 into main Jan 16, 2025
2 checks passed
@bzavhorodskyi bzavhorodskyi deleted the smartling-translation-completed-qejsrfcuuit6-from-main branch January 16, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants