Add retrieve fingerprints page and consolidate - Android SDK #1266
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Hi @DaveMeadAdjust, and thank you for the suggestions. We had discussed them in the past, and I do think they are an improvement over the previous version. Overall, I do believe we can integrate them, although I do have some inline comments. Most are nitpicks or small suggestions, but there is one slightly larger concern regarding non-standard formats (XAPK, APKS, ...).
| | • Huawei AppGallery - App Signing Disabled <br />• Other store, or direct APK download <br />• Local debug build | [Keystore](#from-a-keystore) or [APK](#from-an-apk) | | ||
|
|
||
| #### From Google Play Console {#from-google-play-console} | ||
|
|
There was a problem hiding this comment.
I suggest adding an initial sentence explaining that both the signing key certificate fingerprint and the upload key certificate fingerprint may be required. Otherwise, steps 3 and 4 may be confusing.
|  | ||
|
|
||
| #### From Google Play Console - Internal app sharing {#from-google-play-console---internal-app-sharing} | ||
|
|
There was a problem hiding this comment.
Previously, we required the upload key certificate fingerprint for the internal app sharing case as well. In theory, it's not necessary, and it was asked simply because the old Google page layout had all certificates mixed together (just like in the previous case for release versions), making errors very common. Can you confirm that the Internal app sharing section of the Play Console now shows only a single certificate? If so, then no action is required. Otherwise, please include the upload key certificate fingerprint as well. It will avoid errors.
|
|
||
|  | ||
|
|
||
| 5. If needed, install openssl: |
There was a problem hiding this comment.
Use "OpenSSL", to remain consistent with the official capitalisation when referring to the library by name.
|
|
||
| To retrieve certificate fingerprints from your keystore, follow these steps: | ||
|
|
||
| 1. If needed, install [Android Studio](https://developer.android.com/studio) or Java Development Kit (JDK) to get the `keytool` command. |
There was a problem hiding this comment.
JDK is not required, as keytool comes bundled with any JRE distribution too.
Nitpick The chances that the development team who supposedly created an app doesn't have Android Studio or Java installed are negligible. I would suggest making this an inline observation rather than a full step in the description. Something like: "To retrieve certificate fingerprints from your keystore, follow these steps (Java is assumed to be installed):". A similar comment applies to the next section.
| 1. If needed, install [Android Studio](https://developer.android.com/studio) or Java Development Kit (JDK) to get the `keytool` command. | ||
| 2. Locate your keystore: | ||
| - Self-managed keystore: path to the folder containing your .jks file | ||
| - Android default debug keystore: |
There was a problem hiding this comment.
The debug certificate fingerprints are not necessary anymore. I suggest removing this (and the corresponding commands below) to avoid any confusion.
| [...] | ||
| ``` | ||
|
|
||
| Or different signatures for different Android versions: |
There was a problem hiding this comment.
There may be multiple signatures for the same version. I suggest removing "for different Android versions".
| 55:fb:97:0f:46:0f:94:ec:07:ea:01:69:50:5a:20:3f:a0:91:60:a4:f1:33:58:ea:76:dc:54:9e:a7:6a:b9:1a). | ||
| </Callout> | ||
|
|
||
| ##### Extract APK from other formats {#extract-apk} |
There was a problem hiding this comment.
The XAPK format is not officially supported by Google, and requires a dedicated installer that often re-signs the app (e.g.: APK pure), which will cause the instructions here to fail. The AAB format also requires some post processing, such as uploading it to the Play Console and let it manage signing. The APKS format may be acceptable, but some research would need to be done before confidently marking it as supported. I am against listing any of these formats as officially supported by Adjust, at least when it comes to Signature, as they are non-standard ways of distributing apps, and the instructions here may not always be applicable.
| @@ -0,0 +1,195 @@ | |||
| --- | |||
There was a problem hiding this comment.
Suggested changes in this file also apply in the v5 file.
Related issues
There is some redundant and outdated info for retrieving certificate fingerprints in our documentation.
https://adjustcom.atlassian.net/browse/ADAPP-17894
https://adjustcom.atlassian.net/browse/ADAPP-17907
Changes
Updates instructions and screenshots for retrieving certificate fingerprints to most recent and accurate information. Consolidates steps to retrieve fingerprints into one doc that other docs reference.
Required translations