Reachability notification name clashes with the Apple example

[grigorye]

ios_sdk/Adjust/ADJReachability.m

Line 20 in e207090

NSString *kADJReachabilityChangedNotification = @"kNetworkReachabilityChangedNotification";

kADJReachabilityChangedNotification is defined as "kNetworkReachabilityChangedNotification". This presents a potential issue for any code that integrates Adjust and uses Reachability.m as defined by Apple.

The issue is that any client code that relies on Apple example for Reachability and that observes
all "kNetworkReachabilityChangedNotification" notifications (e.g. passing nil as object to -[NSNotificationCenter addObserver:forName:object:queue:usingBlock:] will get extra notification from Adjust (beware that the client and Adjust might or might not observe different reachability configurations, depending on the situation).

I suggest to change the notification value to something different (like "kADJReachabilityChangedNotification") to avoid the potential clash.

For the reference, there're quite a few mentions of "kNetworkReachabilityChangedNotification" in the Rechability-related examples posted on the Internet, and at quick glance, it's not mentioned anywhere that it's better to use client-specific notification name.

https://www.google.nl/search?q=knetworkreachabilitychangednotification

[uerceg]

Hi @grigorye

Thanks for reporting this. Makes sense. Will be changed in upcoming v4.17.0 release of our SDK. Will keep you posted in here on update progress.

Cheers

[grigorye]

Thanks, @uerceg! Beware though that it might affect clients that happen to (implicitly) depend on Adjust triggering that very notification, due to e.g. a bug in their own reachability tracking. In other words, it might be a "breaking change in case for misbehaving clients".

[uerceg]

Of course and thanks for the comment. It will definitely be mentioned in release notes and CHANGELOG.md entry of the upcoming update.

[uerceg]

@grigorye

This issue is addressed in our latest release, sorry for late ping: #360

Thank you one more time for reporting this.

Cheers! 🍺