Crash after login on Facebook

[Mildwhale]

SDK Version
Adjust: 4.17.0
Facebook: 4.35.0

Environment
Sandbox

Issue
Crash after login on Facebook app randomly.

Location
ADJUtil.m - line: 1299

Step

1. Sign in using Facebook in my app
2. Switch to facebook app
3. Signed in
4. Switch to my app
5. Crash

Stack Trace
<_NSCallStackArray 0x2855fb4e0>(
0 ??? 0x000000010cf54b48 0x0 + 4512369480,
1 DAILYHOTEL 0x000000010561af54 main + 0,
2 CoreFoundation 0x000000018d277df0 _CFStringCreateWithFormatAndArgumentsAux2 + 136,
3 Adjust 0x0000000108568208 -[ADJLogger logLevel:format:parameters:] + 180,
4 Adjust 0x0000000108567cac -[ADJLogger debug:] + 184,
5 Adjust 0x000000010858f2e4 +[ADJUtil isDeeplinkValid:] + 628,
6 Adjust 0x000000010854fd50 -[ADJActivityHandler appWillOpenUrlI:url:clickTime:] + 280,
7 Adjust 0x0000000108547bf0 __51-[ADJActivityHandler appWillOpenUrl:withClickTime:]_block_invoke + 96,
8 Adjust 0x000000010858df88 __42+[ADJUtil launchInQueue:selfInject:block:]_block_invoke + 84,
9 libdispatch.dylib 0x0000000109d9b824 _dispatch_call_block_and_release + 24,
10 libdispatch.dylib 0x0000000109d9cdc8 _dispatch_client_callout + 16,
11 libdispatch.dylib 0x0000000109da4e6c _dispatch_lane_serial_drain + 720,
12 libdispatch.dylib 0x0000000109da5b60 _dispatch_lane_invoke + 460,
13 libdispatch.dylib 0x0000000109dafbfc _dispatch_workloop_worker_thread + 1220,
14 libsystem_pthread.dylib 0x000000018cee50dc _pthread_wqthread + 312,
15 libsystem_pthread.dylib 0x000000018cee7cec start_wqthread + 4
)

[uerceg]

@Mildwhale Can you share the content of the URL which Facebook login window sends back to the app? Having in mind that it might not be something you want to share in public repo, feel free to send it to support@adjust.com and reference this issue in there and it will reach us.

As a temporary fix, you can simply try to check if link belongs to FB in your app before you call appWillOpenUrl method and simply skip making that call to our SDK in that case.

[Mildwhale]

Hi, @uerceg

After 10 minutes, I will send some url to support@adjust.com.

And I rolled back to version 4.14.3 and avoided this issue.
Thank you.

[uerceg]

Great, sounds good. Will get back to you as soon as we examine the URL and see if we can identify what is causing the issue.

[Mildwhale]

@uerceg I sent some urls to support@adjust.com.
The URL was output from the xcode console using the 'po format' command.

[uerceg]

Awesome, thank you so much, we’ll check this and keep you posted in here.

[uerceg]

@Mildwhale

Did each of these links caused the crash?

[Mildwhale]

Of course, that links are what I captured, when a crash cause.

[uerceg]

@Mildwhale

Pretty interesting issue. This actually should not affect your app in production at all, because issue is caused by attempt to print that link you got from FB which only happens in sandbox if log level debug or lower is set. You can give a quick try with latest SDK version when environment is set to production, it should work just fine.

But never the less, upcoming iOS SDK update will address this issue, thanks for reporting it!

[Mildwhale]

I know that this issue only cause in the sandbox environment. But, I thought that it should be corrected.
Thank you for your kind.

Best regard!

[uerceg]

Hi @Mildwhale

We have just updated iOS SDK to v4.17.1 (https://github.com/adjust/ios_sdk/releases/tag/v4.17.1) which should address this issue.

Feel free to give it a shot and let us know if it fixed the issue for you.

Cheers.

[Mildwhale]

Awesome, I've checked that this issue fixed.
Thank you! :)