Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.11.2 #279

Merged
merged 7 commits into from
Mar 14, 2017
Merged

Version 4.11.2 #279

merged 7 commits into from
Mar 14, 2017

Conversation

uerceg
Copy link
Contributor

@uerceg uerceg commented Mar 14, 2017

Changed

  • Changed key name used to save persistent UUID to be unique per app.

@uerceg uerceg merged commit a3462b4 into master Mar 14, 2017
@uerceg uerceg deleted the v4112 branch March 14, 2017 15:47
@Cherryxi
Copy link

Cherryxi commented Mar 17, 2017

app store review can not use performSelector.but I find this API in Adjust source code.Is it a problem?

@uerceg
Copy link
Contributor Author

uerceg commented Mar 17, 2017

@Cherryxi This issue is already discussed within Apple community for some time. You can read about it in here: https://forums.developer.apple.com/thread/73640

Here's one additional article which sums up that discussion: https://9to5mac.com/2017/03/07/apple-cracks-down-on-hot-push-code-sdks/

Key reason for app rejection is this one:

This includes any code which passes arbitrary parameters to dynamic methods such as 
dlopen(), dlsym(), respondsToSelector:, performSelector:, 
method_exchangeImplementations(), and running remote scripts in order to change app 
behavior or call SPI, based on the contents of the downloaded script.

Our SDK doesn't do any of this. Yes, we use this selector, which is part of the official iOS API, but we do not pass any arbitrary parameters to dynamic methods, nor we are downloading some remote source code which is later being executed.

Rollout.io was flagged in here as a problematic component which was causing issue for people in discussion. Are you using Rollout.io maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants