Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory increase issue when continuous writing to file #626

Closed
wants to merge 1 commit into from

Conversation

huiping192
Copy link

No description provided.

@uerceg
Copy link
Contributor

uerceg commented Jul 26, 2022

Hi @huiping192 ,

Thank you very much for the PR. Do you maybe have an example of the memory warning you were facing and which change from this PR has solved?

@uerceg uerceg mentioned this pull request Sep 26, 2022
@uerceg
Copy link
Contributor

uerceg commented Sep 26, 2022

Thank you for your contribution. Adding this change to v4.32.1 and replacing this PR with #633. Please, keep us posted if this change solved your issues. Cheers.

@uerceg uerceg closed this Sep 26, 2022
@uerceg uerceg mentioned this pull request Sep 26, 2022
@huiping192
Copy link
Author

@uerceg Sorry, i`m just forgot to update the pull request detail. Thank you for adding the change. ^^

@uerceg
Copy link
Contributor

uerceg commented Sep 27, 2022

@huiping192 Not a problem at all. Just out of curiosity, were you experiencing just an increased memory consumption in these cases or did you face any crashes because of this issue?

@huiping192
Copy link
Author

@uerceg we face the crash because this issue. In our product send continuous like 200~1000 events will case the memory warning and then app will crash after that. If stop at middle of sending the events the memory usage will back to normal.

We checked that no happened after my commit.

(sorry about the janpanese commit log.. i just notice that. ><

@uerceg
Copy link
Contributor

uerceg commented Sep 27, 2022

No worries at all about Japanese commit message. :) And thank you for additional infos. Can you maybe share crash log reports you were getting when app crashes in this case?

@huiping192
Copy link
Author

Because this happened like 4 mouth ago, i did not keep the crash log. so sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants