Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps adding install referrer to manifest. #144

Closed
feraligatr opened this issue Mar 18, 2019 · 2 comments
Closed

Keeps adding install referrer to manifest. #144

feraligatr opened this issue Mar 18, 2019 · 2 comments

Comments

@feraligatr
Copy link

feraligatr commented Mar 18, 2019

If there's a defined in AndroidManifest.xml, which is not INSTALL_REFERRER, the build script will insert a new receiver every time.

if (!isThereAnyCustomBroadcastReiver)

This code is absolutely wrong.
It should be:
if (isThereAnyCustomBroadcastReiver) { // If there's custom broadcast receiver, let's iterate on "receiver" attributes a bit more to see if it's ours. foreach (XmlAttribute attribute in node.Attributes) { if (attribute.Value.Contains("com.adjust.sdk.AdjustReferrerReceiver")) { isUsedBroadcastReceiverOurs = true; } } break; }

@uerceg
Copy link
Contributor

uerceg commented Mar 18, 2019

Hi @feraligatr

Thanks for reporting and you are absolutely right. We already got this reported last week and you can expect patch update this week which will address this issue.

Will keep you posted.

Cheers

@uerceg uerceg added support and removed support labels Mar 18, 2019
@uerceg uerceg mentioned this issue Mar 21, 2019
@uerceg
Copy link
Contributor

uerceg commented Mar 21, 2019

@feraligatr

Should be fixed in v4.17.1 (https://github.com/adjust/unity_sdk/releases/tag/v4.17.1). In case issue is still there with latest version as well, please feel free to reopen the issue.

Cheers and thanks one more time for reporting! 🍺

@uerceg uerceg closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants