Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deactivateSKAdNetworkHandling set it is true #292

Open
soqman opened this issue Apr 17, 2024 · 1 comment
Open

deactivateSKAdNetworkHandling set it is true #292

soqman opened this issue Apr 17, 2024 · 1 comment

Comments

@soqman
Copy link

soqman commented Apr 17, 2024

adjustConfig.deactivateSKAdNetworkHandling() makes skAdNetworkHandling = true. is it correct?

@uerceg
Copy link
Contributor

uerceg commented Apr 17, 2024

Hey @soqman,

Great and legit question. Short answer: yes and it does sound pretty odd, but:

  • The value of skAdNetworkHandling is late being processed here.
  • As you can see, its value (true) is being stored into variable which is named deactivateSkAdNetworkHandling which now sounds like it makes much more sense.
  • Later that value is being passed to the native layer where if it's set, it will be used to actually deactivate SKAdNetwork handling natively.
  • It's set if it's not -1, which is default value for not set nullable boolean (more info) which skAdNetworkHandling is. Which technically means that even if one would assign false to skAdNetoworkHandling, it would technically cause native deactivation to happen. But since no code path is setting that, it should be that only setting it to true (the call to the method and assigning from your initial comment) causes disabling on the native level.

Definitely a confusing path in the code thanks to poor naming of things on our end and something that should be changed (and it will be changed soon).

Hopefully this clears things up for you and thanks for the question.

If you still have some questions / comments, feel free to ask.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants