Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.24.1 #199

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Version 4.24.1 #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9459f6
fix costAmount parsing logic to handle null native values
uerceg Dec 24, 2020
36d1c5d
update version number to 4.24.1
uerceg Dec 24, 2020
b64b217
update changelog
uerceg Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Assets/Adjust/Android/AdjustAndroid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace com.adjust.sdk
#if UNITY_ANDROID
public class AdjustAndroid
{
private const string sdkPrefix = "unity4.24.0";
private const string sdkPrefix = "unity4.24.1";
private static bool launchDeferredDeeplink = true;
private static AndroidJavaClass ajcAdjust = new AndroidJavaClass("com.adjust.sdk.Adjust");
private static AndroidJavaObject ajoCurrentActivity = new AndroidJavaClass("com.unity3d.player.UnityPlayer").GetStatic<AndroidJavaObject>("currentActivity");
Expand Down
20 changes: 18 additions & 2 deletions Assets/Adjust/Unity/AdjustAttribution.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,16 @@ public AdjustAttribution(string jsonString)
clickLabel = AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyClickLabel);
adid = AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyAdid);
costType = AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyCostType);
costAmount = double.Parse(AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyCostAmount),
try
{
costAmount = double.Parse(AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyCostAmount),
System.Globalization.CultureInfo.InvariantCulture);
}
catch (Exception)
{
// attribution response doesn't contain cost amount attached
// value will default to null
}
costCurrency = AdjustUtils.GetJsonString(jsonNode, AdjustUtils.KeyCostCurrency);
}

Expand All @@ -57,8 +65,16 @@ public AdjustAttribution(Dictionary<string, string> dicAttributionData)
clickLabel = AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyClickLabel);
adid = AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyAdid);
costType = AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyCostType);
costAmount = double.Parse(AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyCostAmount),
try
{
costAmount = double.Parse(AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyCostAmount),
System.Globalization.CultureInfo.InvariantCulture);
}
catch (Exception)
{
// attribution response doesn't contain cost amount attached
// value will default to null
}
costCurrency = AdjustUtils.TryGetValue(dicAttributionData, AdjustUtils.KeyCostCurrency);
}
}
Expand Down
2 changes: 1 addition & 1 deletion Assets/Adjust/Windows/AdjustWindows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace com.adjust.sdk
{
public class AdjustWindows
{
private const string sdkPrefix = "unity4.24.0";
private const string sdkPrefix = "unity4.24.1";
private static bool appLaunched = false;

public static void Start(AdjustConfig adjustConfig)
Expand Down
2 changes: 1 addition & 1 deletion Assets/Adjust/iOS/AdjustiOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace com.adjust.sdk
#if UNITY_IOS
public class AdjustiOS
{
private const string sdkPrefix = "unity4.24.0";
private const string sdkPrefix = "unity4.24.1";

[DllImport("__Internal")]
private static extern void _AdjustLaunchApp(
Expand Down
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
### Version 4.24.1 (24th December 2020)
#### Fixed
- Fixed handling of native `null` values for cost amount.

#### Native SDKs
- [iOS@v4.24.0][ios_sdk_v4.24.0]
- [Android@v4.25.0][android_sdk_v4.25.0]
- [Windows@v4.17.0][windows_sdk_v4.17.0]

---

### Version 4.24.0 (11th December 2020)
#### Added
- Added possibility to get cost data information in attribution callback.
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4.24.0
4.24.1
2 changes: 1 addition & 1 deletion doc/english/migration/migrate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## Migrate your Adjust SDK for Unity3d to 4.24.0 from 3.4.4
## Migrate your Adjust SDK for Unity3d to 4.24.1 from 3.4.4

### Migration procedure

Expand Down