-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BinanceAPI Constructor and add API calls #3
base: master
Are you sure you want to change the base?
Conversation
- Reason(s): - Change(s): - Reference(s):
… server time. - Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
- Reason(s): - Change(s): - Reference(s):
Only issue with removing functions is I'm trying to be consistent with the other exchange APIs as I have a 'cryptoexchange' wrapper package which utilises the bittrex, binance, cryptopia & kraken API packages I've written. The aim was to provide consistent functions & return values to make it easy to switch between exchanges within the code. |
Hmm... I'll update it with the removed methods for backwards compatibility. Probably won't be able to get to it until tomorrow though. |
Setup the
__construct()
so that you can callBinanceAPI
outside of the alias/facade. Similar to what you have setup on your laravel-bittrex packageI added more public API calls based on these docs: https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md
Interestingly enough,
v1/ticker/allPrices
isn't mentioned ANYWHERE but it is a valid call with yourgetTickers()
method.New methods include:
I removed
getTicker()
because it returned the exact same information asgetTickers()
. I also removedgetCurrencies()
because there was no need for it.