Skip to content

Commit

Permalink
[core] fix: don't render "asyncControl" as HTML attr (palantir#4384)
Browse files Browse the repository at this point in the history
  • Loading branch information
adidahiya authored Oct 22, 2020
1 parent 0b3edfc commit ed40d65
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/core/src/common/props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export interface IOptionProps extends IProps {
const INVALID_PROPS = [
"active",
"alignText",
"asyncControl", // IInputGroupProps
"containerRef",
"current",
"elementRef",
Expand Down
3 changes: 3 additions & 0 deletions packages/core/src/components/forms/asyncControllableInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import * as React from "react";
import { polyfill } from "react-lifecycles-compat";
import { DISPLAYNAME_PREFIX } from "../../common/props";

export interface IAsyncControllableInputProps
extends React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> {
Expand Down Expand Up @@ -64,6 +65,8 @@ export class AsyncControllableInput extends React.PureComponent<
IAsyncControllableInputProps,
IAsyncControllableInputState
> {
public static displayName = `${DISPLAYNAME_PREFIX}.AsyncControllableInput`;

public state: IAsyncControllableInputState = {
hasPendingUpdate: false,
isComposing: false,
Expand Down

0 comments on commit ed40d65

Please sign in to comment.