Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from nalgeon:main #65

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[pull] main from nalgeon:main #65

merged 4 commits into from
Feb 11, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 11, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Prevent crashes when handling empty fields in CSV rows and add error handling for calling defined functions after they have been freed.

New Features:

  • Add error handling to prevent crashes when calling defined functions after they have been freed.

Tests:

  • Handle empty fields at the beginning of CSV rows.

@pull pull bot added the ⤵️ pull label Feb 11, 2025
@pull pull bot merged commit b9ba442 into admariner:main Feb 11, 2025
Copy link

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This pull request introduces several key enhancements: improvements to cache management in defined functions with additional state tracking, updates to the README documentation regarding support and copyright information, and a fix in the extension module to handle empty fields correctly.

State Diagram for Cache Management in Defined Functions

stateDiagram-v2
    [*] --> Active: Initialize (cache_freed = false)
    Active --> Executing: Call define_exec()/define_function()
    note right of Active: Normal execution returns success
    Executing --> Active: Execution complete
    Active --> Freed: Call cache_free()
    Freed --> Error: Any call to define_exec()/define_function()
    note right of Freed: Returns SQLITE_MISUSE error
Loading

File-Level Changes

Change Details Files
Enhanced cache management in defined functions
  • Added a boolean flag to track whether the cache has been freed.
  • Guarded cache-related operations in cache_print, define_exec, and define_function to prevent usage after cache is freed.
  • Updated cache_free function to set the new flag after clearing the cache.
src/define/manage.c
Refactored README documentation
  • Renamed the 'Funding' section to 'Support'.
  • Updated copyright information to extend the copyright year.
README.md
Fixed handling of empty fields in the extension reader src/vsv/extension.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant