Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sighup term support ? #352

Closed
lukasmrtvy opened this issue Oct 21, 2019 · 1 comment
Closed

sighup term support ? #352

lukasmrtvy opened this issue Oct 21, 2019 · 1 comment
Assignees
@moorereason
Labels
enhancement
Milestone
2.7.0

Comments

@lukasmrtvy
Copy link

Seems that webhook does not handle term signaling, sighup is not recognized, supevisor is forced to send sigterm.
@moorereason moorereason added this to the 2.7.0 milestone Dec 25, 2019
moorereason added a commit to moorereason/webhook that referenced this issue Dec 25, 2019
@moorereason
Add SIGHUP support
c6c270c 
Fixes adnanh#352
@moorereason moorereason self-assigned this Dec 25, 2019
@moorereason moorereason mentioned this issue Dec 25, 2019
Merged
@adnanh
Copy link
Owner

adnanh commented Dec 26, 2019

Due to #378, as of 2.7.0, SIGHUP will force webhook to reload configuration.

@adnanh adnanh closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moorereason moorereason

Labels
enhancement
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
3 participants
@adnanh @moorereason @lukasmrtvy