Fix invalid assumption that multipart forms can be parsed in te same way as urlencoded forms. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same way as urlencoded forms. Refactored code to use switch-case statement over the `Content-Type` header and log unsupported content types instead of silently failing. Also made the `x-www-form-urlencoded` content type handler more specific (as opposed to the previous code which looked for `form` occurence in the value), as we need to use different logic for multipart forms, which we'll hopefully implement soon. The issue with multipart forms that we have to handle first is that the files are being written to temporary files, and as such, for async hooks webhook cannot guarantee they'll be available after we close the request; that, and the fact that we don't have code that will properly serialize and pass such Golang objects to the script, as there are several fields which might be interesting to the end user.
This was referenced Dec 2, 2019
moorereason
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored code to use switch-case statement over the
Content-Typeheader and log unsupported content types instead of silently failing.Also made the
x-www-form-urlencodedcontent type handler more specific (as opposed to the previous code which looked forformoccurence in the value),as we need to use different logic for multipart forms, which we'll hopefully implement soon.