Skip to content

Raise Error when JSON body contains errors #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Raise Error when JSON body contains errors #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion umapi_client/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,16 @@ class APIResult:

def __init__(self, result=None, success=False, timeout=None):
self.result = result
try:
self.result_details = result.json()
except ValueError:
self.result_details = {}
self.success = success
self.timeout = timeout
self.status_code = result.status_code if hasattr(result, 'status_code') else 'Error'

def check_result(self):
if self.result.status_code in self.success_codes:
if self.result.status_code in self.success_codes and not self.result_details.get('errors'):
self.success = True
return self
if self.result.status_code in self.timeout_codes:
Expand Down