Fix aj16-kanji.txt for added JP glyphs #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.000 has added JP glyphs uni54E5-JP and uni68D7-JP. However, aj16-kanji.txt contains uni54E5-CN and uni68D7-CN, which were used for JP glyphs in version 1.001. This commit fixes the glyph names in aj16-kanji.txt to the added JP glyph names.
|
There are more than just these two glyphs that weren't updated properly in the aj16-kanji.txt file. I've fixed it and it will be in the next release. I also added a test to the test suite to make sure this can't ever happen again. |
Closed
3 tasks
3 tasks
trueroad
added a commit
to trueroad/HaranoAjiFonts-generator
that referenced
this pull request
Nov 1, 2021
Due to some issues with SourceHanSerif version 2.000, the HaranoAjiFonts-generator was not able to generate HaranoAjiMincho. This commit introduces some workarounds until SourceHanSerif is fixed. adobe-fonts/source-han-serif#123 Fix glyph names in aj16-kanji.txt. uni54E5-CN -> uni54E5-JP uni68D7-CN -> uni68D7-JP adobe-fonts/source-han-serif#125 Remove two glyphs that are not contained in SourceHanSerifJP. AJ1 CID+13729 AJ1 CID+14019 This causes the two glyphs in HaranoAjiMincho to be missing until SourceHanSerifJP is fixed in its next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.000 has added JP glyphs uni54E5-JP and uni68D7-JP.
However, aj16-kanji.txt contains uni54E5-CN and uni68D7-CN,
which were used for JP glyphs in version 1.001.
This commit fixes the glyph names in aj16-kanji.txt
to the added JP glyph names.