Probe branch: Failing test for missing probe. #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the first initializer in
var b = 2, c = 3
isn't probed.tracer.traceProbeValue
is actually called but the corresponding nodeId doesn't exist in the list of nodeIds sent totracer.add
, so it seems to be dropped.I saw that you implied work on nodeIds wasn't quite complete, and I'm still working out how Fondue works well enough to contribute a patch, but I was able to at least produce this failing test to demonstrate the problem. I'm offering it as this PR if it's useful to you.