test: Fix component delete function in UE #165
Conversation
| // eslint-disable-next-line no-await-in-loop | ||
| await adaptiveFormPath.first().click(); | ||
|
|
||
| // eslint-disable-next-line max-len,no-await-in-loop | ||
| const isComponentSelected = await frame.locator(this.componentSelectorValidation(component)).isVisible(); |
There was a problem hiding this comment.
componentSelectorValidation is coupled with text-input. this makes the code confusing to understand.
we should just have an API to get the selected component from the content tree and then decide whether it's a form or not.
| const isAdaptiveFormSelected = await frame.locator(this.selectors.selectedAdaptiveFormWithComponent).isVisible(); | ||
|
|
||
| // eslint-disable-next-line no-await-in-loop | ||
| if (!isComponentSelected && isAdaptiveFormSelected) { |
There was a problem hiding this comment.
avoid too many eslint disables. better to take out these lines as a separate func outside while
|
|
||
| // eslint-disable-next-line no-await-in-loop | ||
| if (!isComponentSelected && isAdaptiveFormSelected) { | ||
| const expandButton = frame.locator(this.getExpandCollapseButton('Expand')); |
There was a problem hiding this comment.
lets have a common method to expand the component in the tree
| // eslint-disable-next-line no-await-in-loop | ||
| await frame.locator(`li[data-resource*="/${component}"]`).click(); | ||
| // eslint-disable-next-line no-await-in-loop,max-len | ||
| expect(await frame.locator(this.componentSelectorValidation(component)).isVisible()).toBe(true); |
There was a problem hiding this comment.
lets have a isComponentSelected method.
| if (await frame.locator(this.selectors.adaptiveFormPathInContentTree).isVisible()) { | ||
| break; | ||
| } | ||
|
|
||
| // eslint-disable-next-line no-await-in-loop | ||
| await frame.locator(this.selectors.deleteButton).click(); |
There was a problem hiding this comment.
common method to deleteComponent is required here.
|
The tests code is quite unreadable at present and thus, not maintainable.
|
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: