-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify and split models/definition/filters files #30
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
A few suggestions:
|
Very good suggestion as this allows
|
Hi all, |
This will be merged after the next AEM Cloud Services release scheduled for this / next week. The majority of changes can be used. Unfortunately I made some changes to the default content models (button, title, image) and rename the fields according to our naming conventions so that they can be used in container blocks without any changes. This change is the only thing that requires the AEM CS release. Spitting/merging the files works today. |
valueType
,value
, ...)Each block now has a
_component.json
partial with a json object that containsdefinitions
,models
andfilters
. Each of them is an array as a block may expose 0..n of either of them. The default content model partials are now stored inmodels/
as well as the partials for component-models.json, component-definition.json and component-filters.json. The file name format with the leading_
was inspired by sass partials (files that are meant to be imported into other files).Besides that this commit adds
husky
pre-commit hook support, with a simple hook that merges the models/definition/filters files if any of the partials changed.