fix: allow headers in config

adobe-rnd · Sep 30, 2024 · 627a77c · 627a77c
1 parent d79b0f2
commit 627a77c
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 0 deletions.
diff --git a/src/config.js b/src/config.js
@@ -61,12 +61,17 @@ export async function resolveConfig(ctx, tenant, overrides = {}) {
     ...paths.reduce((conf, key) => ({
       ...conf,
       ...confMap[key],
+      headers: {
+        ...conf.headers,
+        ...(confMap[key]?.headers ?? {}),
+      },
       params: {
         ...conf.params,
         ...extractPathParams(key, suffix),
       },
     }), {
       ...(confMap.base ?? {}),
+      headers: confMap.base?.headers ?? {},
       params: {},
     }),
     ...overrides,

diff --git a/src/index.js b/src/index.js
@@ -33,6 +33,7 @@ async function fetchProduct(sku, config) {
       'Magento-Website-Code': config.magentoWebsiteCode,
       'Magento-Store-View-Code': config.magentoStoreViewCode,
       'Magento-Store-Code': config.magentoStoreCode,
+      ...config.headers,
     },
   });
   if (!resp.ok) {
@@ -72,6 +73,7 @@ async function fetchVariants(sku, config) {
       'Magento-Website-Code': config.magentoWebsiteCode,
       'Magento-Store-View-Code': config.magentoStoreViewCode,
       'Magento-Store-Code': config.magentoStoreCode,
+      ...config.headers,
     },
   });
   if (!resp.ok) {
@@ -110,6 +112,7 @@ async function lookupProductSKU(urlkey, config) {
       'Magento-Website-Code': config.magentoWebsiteCode,
       'Magento-Store-View-Code': config.magentoStoreViewCode,
       'Magento-Store-Code': config.magentoStoreCode,
+      ...config.headers,
     },
   });
   if (!resp.ok) {

diff --git a/src/types.d.ts b/src/types.d.ts
@@ -12,6 +12,7 @@ declare global {
     coreEndpoint: string;
     catalogEndpoint?: string;
     params: Record<string, string>;
+    headers: Record<string, string>;
   }
 
   export interface Env {

diff --git a/test/config.test.js b/test/config.test.js
@@ -52,6 +52,39 @@ describe('config tests', () => {
     assert.deepStrictEqual(config, {
       apiKey: 'good',
       params: { urlkey: 'my-url-key', sku: 'some-sku' },
+      headers: {},
+      pageType: 'product',
+    });
+  });
+
+  it('should combine headers objects', async () => {
+    const tenantConfigs = {
+      'test-tenant': {
+        base: {
+          apiKey: 'bad',
+          headers: {
+            foo: '1',
+            baz: '1',
+          },
+        },
+        '/us/p/{{urlkey}}/{{sku}}': {
+          pageType: 'product',
+          apiKey: 'good',
+          headers: {
+            foo: '2',
+            bar: '2',
+          },
+        },
+      },
+    };
+    const config = await resolveConfig(
+      TEST_CONTEXT('/us/p/my-url-key/some-sku', tenantConfigs),
+      'test-tenant',
+    );
+    assert.deepStrictEqual(config, {
+      apiKey: 'good',
+      params: { urlkey: 'my-url-key', sku: 'some-sku' },
+      headers: { foo: '2', baz: '1', bar: '2' },
       pageType: 'product',
     });
   });
@@ -75,6 +108,7 @@ describe('config tests', () => {
     assert.deepStrictEqual(config, {
       apiKey: 'good',
       params: { sku: 'some-sku' },
+      headers: {},
       pageType: 'product',
     });
   });
@@ -100,6 +134,7 @@ describe('config tests', () => {
       apiKey: 'good',
       params: { sku: 'some-sku' },
       pageType: 'product',
+      headers: {},
     });
   });
 });