Memory leak when removing an element.

[zhaostu]

Doing a code search, I found that all elements created by Snap.svg are stored in a context variable hub:
https://github.com/adobe-webplatform/Snap.svg/blob/master/dist/snap.svg.js#L838

No element are ever removed from hub, even if element.remove() is called. Thus, if a large amount of objects are added and then removed, it will create a really bad memory leak as no element object, or the corresponding detached DOM element is freed from memory.

Also since hub is a context variable created in a closure, I cannot release the object even manually.

Please provide a method on Element object to remove the element from hub object and let GC to collect it.

[zhaostu]

In order to illustrate this, I created a jsbin http://jsbin.com/bapuxo/2/edit, that if you click "Go", it will leak memory.

[zhaostu]

@DmitryBaranovskiy Thank you for the fast fix. But I would suggest maybe a element.destory() method could give the user more control (although more coding)? Or element.remove() will always detach the element from hub? Or maybe an option in element.remove(true) to specify the intention that the element will never be used.

Ideas?

[DmitryBaranovskiy]

This would make sense if Snap API was the only way user could interact with the DOM. What if whole <div> that contained SVG element was deleted or div.innerHTML = "";, not to mention direct operation of SVG DOM.

[zhaostu]

@DmitryBaranovskiy Make sense, thanks.