Skip to content

Conversation

cabanier
Copy link
Contributor

fixes #32

@rhauck
Copy link
Collaborator

rhauck commented Sep 12, 2014

Nice graphic! I think it's in the wrong place on the page though. It should be after the first paragraph in the What is it? section. Also, I think there should be a short descriptive sentence. Something like "The following example is an SVG image animated with CSS."

Last, I'd link to actual pen with the text "See the full source on CodePen" > http://codepen.io/miukimiu/pen/Igouf and then Credit: Elizabet Oliveira with the link to her main codepen page.

@rhauck
Copy link
Collaborator

rhauck commented Sep 12, 2014

I still see some issues with this. First issue is that the Adobe logo in the upper left corner seems to have gotten the bg color of this graphic. See:

image

Next, the height of it goes full screen on iPad (mini & regular). See:

image

@cabanier
Copy link
Contributor Author

Fixed the issue. verified it's displaying correctly on safari

@rhauck
Copy link
Collaborator

rhauck commented Sep 12, 2014

Ok, verified both the bg of the logo and the size on the tablet. One more little nit: can you center the credit text at the bottom of the graphic?

@cabanier
Copy link
Contributor Author

done

@rhauck
Copy link
Collaborator

rhauck commented Sep 12, 2014

Sweet. Thanks @cabanier!

rhauck added a commit that referenced this pull request Sep 12, 2014
@rhauck rhauck merged commit f3f6731 into adobe-webplatform:master Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG page has no image in it
2 participants