Let CopyObject overwrite store headers

The headers we store as "storeHeaders" are part of the "System-defined object metadata" which can be the only metadata overwritten when copying objects. Fixes #2005
adobe · Sep 27, 2024 · a7d6b5d · a7d6b5d
1 parent 7b46711
commit a7d6b5d
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 11 deletions.
diff --git a/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/CopyObjectV2IT.kt b/integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/CopyObjectV2IT.kt
@@ -349,4 +349,43 @@ internal class CopyObjectV2IT : S3TestBase() {
       assertThat(it.response().storageClass()).isEqualTo(StorageClass.STANDARD_IA)
     }
   }
+
+  @Test
+  @S3VerifiedTodo
+  fun testCopyObject_overwriteStoreHeader(testInfo: TestInfo) {
+    val sourceKey = UPLOAD_FILE_NAME
+    val uploadFile = File(UPLOAD_FILE_NAME)
+    val bucketName = givenBucketV2(testInfo)
+
+    s3ClientV2.putObject(
+      PutObjectRequest.builder()
+        .bucket(bucketName)
+        .key(sourceKey)
+        .contentDisposition("")
+        .build(),
+      RequestBody.fromFile(uploadFile)
+    )
+
+    val destinationBucketName = givenRandomBucketV2()
+    val destinationKey = "copyOf/$sourceKey"
+
+    s3ClientV2.copyObject(CopyObjectRequest
+      .builder()
+      .sourceBucket(bucketName)
+      .sourceKey(sourceKey)
+      .destinationBucket(destinationBucketName)
+      .destinationKey(destinationKey)
+      .metadataDirective(MetadataDirective.REPLACE)
+      .contentDisposition("attachment")
+      .build())
+
+    s3ClientV2.getObject(GetObjectRequest
+      .builder()
+      .bucket(destinationBucketName)
+      .key(destinationKey)
+      .build()
+    ).use {
+      assertThat(it.response().contentDisposition()).isEqualTo("attachment")
+    }
+  }
 }
diff --git a/server/src/main/java/com/adobe/testing/s3mock/ObjectController.java b/server/src/main/java/com/adobe/testing/s3mock/ObjectController.java
@@ -696,17 +696,20 @@ public ResponseEntity<CopyObjectResult> copyObject(@PathVariable String bucketNa
     var s3ObjectMetadata = objectService.verifyObjectExists(copySource.bucket(), copySource.key());
     objectService.verifyObjectMatchingForCopy(match, noneMatch, s3ObjectMetadata);
 
-    Map<String, String> metadata = Collections.emptyMap();
+    Map<String, String> userMetadata = Collections.emptyMap();
+    Map<String, String> storeHeaders = Collections.emptyMap();
     if (MetadataDirective.REPLACE == metadataDirective) {
-      metadata = userMetadataFrom(httpHeaders);
+      userMetadata = userMetadataFrom(httpHeaders);
+      storeHeaders = storeHeadersFrom(httpHeaders);
     }
 
     var copyObjectResult = objectService.copyS3Object(copySource.bucket(),
         copySource.key(),
         bucketName,
         key.key(),
         encryptionHeadersFrom(httpHeaders),
-        metadata,
+        storeHeaders,
+        userMetadata,
         storageClass);
 
     //return version id / copy source version id

diff --git a/server/src/main/java/com/adobe/testing/s3mock/service/ObjectService.java b/server/src/main/java/com/adobe/testing/s3mock/service/ObjectService.java
@@ -80,6 +80,7 @@ public CopyObjectResult copyS3Object(String sourceBucketName,
       String destinationBucketName,
       String destinationKey,
       Map<String, String> encryptionHeaders,
+      Map<String, String> storeHeaders,
       Map<String, String> userMetadata,
       StorageClass storageClass) {
     var sourceBucketMetadata = bucketStore.getBucketMetadata(sourceBucketName);
@@ -93,8 +94,9 @@ public CopyObjectResult copyS3Object(String sourceBucketName,
     if (sourceKey.equals(destinationKey) && sourceBucketName.equals(destinationBucketName)) {
       return objectStore.pretendToCopyS3Object(sourceBucketMetadata,
           sourceId,
-          userMetadata,
           encryptionHeaders,
+          storeHeaders,
+          userMetadata,
           storageClass);
     }
 
@@ -103,7 +105,7 @@ public CopyObjectResult copyS3Object(String sourceBucketName,
     try {
       return objectStore.copyS3Object(sourceBucketMetadata, sourceId,
           destinationBucketMetadata, destinationId, destinationKey,
-          encryptionHeaders, userMetadata, storageClass);
+          encryptionHeaders, storeHeaders, userMetadata, storageClass);
     } catch (Exception e) {
       //something went wrong with writing the destination file, clean up ID from BucketStore.
       bucketStore.removeFromBucket(destinationKey, destinationBucketName);

diff --git a/server/src/main/java/com/adobe/testing/s3mock/store/ObjectStore.java b/server/src/main/java/com/adobe/testing/s3mock/store/ObjectStore.java
@@ -305,6 +305,7 @@ public CopyObjectResult copyS3Object(BucketMetadata sourceBucket,
       UUID destinationId,
       String destinationKey,
       Map<String, String> encryptionHeaders,
+      Map<String, String> storeHeaders,
       Map<String, String> userMetadata,
       StorageClass storageClass) {
     var sourceObject = getS3ObjectMetadata(sourceBucket, sourceId);
@@ -316,7 +317,8 @@ public CopyObjectResult copyS3Object(BucketMetadata sourceBucket,
           destinationId,
           destinationKey,
           sourceObject.contentType(),
-          sourceObject.storeHeaders(),
+          storeHeaders == null || storeHeaders.isEmpty()
+              ? sourceObject.storeHeaders() : storeHeaders,
           sourceObject.dataPath(),
           userMetadata == null || userMetadata.isEmpty()
               ? sourceObject.userMetadata() : userMetadata,
@@ -340,15 +342,16 @@ public CopyObjectResult copyS3Object(BucketMetadata sourceBucket,
    */
   public CopyObjectResult pretendToCopyS3Object(BucketMetadata sourceBucket,
       UUID sourceId,
-      Map<String, String> userMetadata,
       Map<String, String> encryptionHeaders,
+      Map<String, String> storeHeaders,
+      Map<String, String> userMetadata,
       StorageClass storageClass) {
     var sourceObject = getS3ObjectMetadata(sourceBucket, sourceId);
     if (sourceObject == null) {
       return null;
     }
 
-    verifyPretendCopy(sourceObject, userMetadata, encryptionHeaders, storageClass);
+    verifyPretendCopy(sourceObject, userMetadata, encryptionHeaders, storeHeaders, storageClass);
 
     writeMetafile(sourceBucket, new S3ObjectMetadata(
         sourceObject.id(),
@@ -365,7 +368,8 @@ public CopyObjectResult pretendToCopyS3Object(BucketMetadata sourceBucket,
         sourceObject.legalHold(),
         sourceObject.retention(),
         sourceObject.owner(),
-        sourceObject.storeHeaders(),
+        storeHeaders == null || storeHeaders.isEmpty()
+            ? sourceObject.storeHeaders() : storeHeaders,
         encryptionHeaders == null || encryptionHeaders.isEmpty()
             ? sourceObject.encryptionHeaders() : encryptionHeaders,
         sourceObject.checksumAlgorithm(),
@@ -378,11 +382,16 @@ public CopyObjectResult pretendToCopyS3Object(BucketMetadata sourceBucket,
   private void verifyPretendCopy(S3ObjectMetadata sourceObject,
                                  Map<String, String> userMetadata,
                                  Map<String, String> encryptionHeaders,
+                                 Map<String, String> storeHeaders,
                                  StorageClass storageClass) {
     var userDataUnChanged = userMetadata == null || userMetadata.isEmpty();
     var encryptionHeadersUnChanged = encryptionHeaders == null || encryptionHeaders.isEmpty();
+    var storeHeadersUnChanged = storeHeaders == null || storeHeaders.isEmpty();
     var storageClassUnChanged = storageClass == null || storageClass == sourceObject.storageClass();
-    if (userDataUnChanged && storageClassUnChanged && encryptionHeadersUnChanged) {
+    if (userDataUnChanged
+        && storageClassUnChanged
+        && encryptionHeadersUnChanged
+        && storeHeadersUnChanged) {
       throw INVALID_COPY_REQUEST_SAME_KEY;
     }
   }

diff --git a/server/src/main/java/com/adobe/testing/s3mock/store/S3ObjectMetadata.java b/server/src/main/java/com/adobe/testing/s3mock/store/S3ObjectMetadata.java
@@ -35,6 +35,7 @@
 
 /**
  * Represents an object in S3, used to serialize and deserialize all metadata locally.
+ * <a href="https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingMetadata.html">See API</a>
  */
 public record S3ObjectMetadata(
     UUID id,

diff --git a/server/src/test/kotlin/com/adobe/testing/s3mock/store/ObjectStoreTest.kt b/server/src/test/kotlin/com/adobe/testing/s3mock/store/ObjectStoreTest.kt
@@ -250,7 +250,7 @@ internal class ObjectStoreTest : StoreTestBase() {
     objectStore.copyS3Object(
       metadataFrom(sourceBucketName), sourceId,
       metadataFrom(destinationBucketName),
-      destinationId, destinationObjectName, emptyMap(), NO_USER_METADATA, StorageClass.STANDARD_IA
+      destinationId, destinationObjectName, emptyMap(), emptyMap(), NO_USER_METADATA, StorageClass.STANDARD_IA
     )
 
     objectStore.getS3ObjectMetadata(metadataFrom(destinationBucketName), destinationId).also {
@@ -288,6 +288,7 @@ internal class ObjectStoreTest : StoreTestBase() {
       destinationId,
       destinationObjectName,
       encryptionHeaders(),
+      emptyMap(),
       NO_USER_METADATA,
       StorageClass.STANDARD_IA
     )