Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate checksums for uploads and parts #1827

Closed
afranken opened this issue Apr 30, 2024 · 0 comments · Fixed by #1828
Closed

Validate checksums for uploads and parts #1827

afranken opened this issue Apr 30, 2024 · 0 comments · Fixed by #1828
Assignees
@afranken
Labels
bug

Comments

@afranken
Copy link
Member

Let S3Mock validate incoming checksums and throw errors when they do not match the received byte stream:
#1205 (comment)
https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/s3-checksums.html

After implementing #1662 it was easy to implement validation of incoming checksums.
We still do not persist Part metadata (see #1205), but at least we can validate checksums during a part upload.
The UploadPart API will now also return the checksum to the client.

See #1205, #1818, #1662
@afranken afranken added the bug label Apr 30, 2024
@afranken afranken self-assigned this Apr 30, 2024
afranken added a commit that referenced this issue Apr 30, 2024
@afranken
Verify checksums on upload
6b38d5c 
This works for regular uploads and parts now.
UploadPart API now returns the checksum.

Fixes #1827
This was referenced Apr 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afranken afranken

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify checksums on upload adobe/S3Mock
1 participant
@afranken