Correctly handle unsigned chunked uploads #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranken
force-pushed
the
1662-fix-multipart-upload-problems
branch
from
d62fb0e
to
1274eb6
Compare
Many hard-coded paths, sizes etc make it hard to test with files other than the default "sampleFile.txt" which is 36bytes in size. Using even slightly larger payloads leads to errors during uploads. #1662
afranken
force-pushed
the
1662-fix-multipart-upload-problems
branch
3 times, most recently
from
3c3ce24
to
ee58208
Compare
Some http clients (like the AWS SDKs) do not cope well if we return errors from APIs before consuming the incoming stream. Make sure we always consume all bytes before processing the streams. #1662
afranken
force-pushed
the
1662-fix-multipart-upload-problems
branch
from
ee58208
to
8fb575b
Compare
This just uses AWS SDKv2 utility classes for doing the heavy lifting.
Use more Kotlin constructs Make tests more readable Make tests more stable for exchanging the default input file
Make tests more stable for exchanging the default input file
Write incoming streams directly to a temp file, removing chunk information, optionally read checksum information. Fixes #1662
afranken
force-pushed
the
1662-fix-multipart-upload-problems
branch
from
af0fa6a
to
9f41990
Compare
afranken
changed the title
This updates Jetty to 12.0.8 where they changed the UriCompliance yet again. We need to use "UNSAFE" now. jetty/jetty.project#11495
afranken
force-pushed
the
1662-fix-multipart-upload-problems
branch
from
1d07b75
to
3468740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#1662
Tasks