-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clients to customize s3mock server TLS certificate #231
Conversation
fdb7e3d
to
d2fe467
Compare
@agudian , would you please review? |
29456f0
to
2f80532
Compare
This enables to use a regular S3 client with full TLS verification
@agudian , I'm sorry I give up. I can't build the project locally (see #235 ), and the build error messages like the following are completely insane.
I do understand the necessity of the legal stuff, however, ill error messages are completely demotivating, and I don't want to spend my time fighting with Checkstyle / Maven. It would be great if you could remove license-maven-plugin / Checkstyle from your build completely. Please feel free to reject my PRs. Have a nice day. |
@vlsi So sorry to hear that, fighting with a bad developer experience like you did is always a bummer and I totally get it. That building locally doesn't work for you is bad enough, and that the checkstyle warnings don't help is similarly bad. Add to that the lack of response from me (was on vacation). So I understand your frustration, and thanks for your effort anyway. If you still have a need for your contributions here, let me know and I'll fix up the PR (I think the license header should contain |
Vacation is great.
Well, I can try adding |
Ok, |
lawyers, right? 🤷 Thanks a lot! I'll add you to the contributors list and run a release build. |
This enables to use of a regular S3 client with full TLS verification.
Related Issue
#230
Tasks