Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get- / Put- ObjectAcl #819

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Add Get- / Put- ObjectAcl #819

merged 4 commits into from
Sep 26, 2022

Conversation

afranken
Copy link
Member

@afranken afranken commented Sep 18, 2022

Description

  • Features and fixes
    • Add support for ACL APIs (fixes S3Mock overwrites file data with ACL XML on 'putObject' #213 / Cannot get ACL for new object #290)
      • Implement GetObjectACL / PutObjectACL
      • Return / accept String instead of a POJO. We need to use JAX-B annotations instead of Jackson annotations
        because AWS decided to use xsi:type annotations in the XML representation, which are not supported
        by Jackson. It doesn't seem to be possible to use bot JAX-B and Jackson for (de-)serialization in parallel.

Related Issue

fixes #213
fixes #290

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

@afranken afranken self-assigned this Sep 18, 2022
@afranken afranken force-pushed the add-acl-handling branch 7 times, most recently from 38462e9 to 5d4c0da Compare September 25, 2022 20:56
afranken and others added 4 commits September 26, 2022 14:21
Implement GetObjectACL / PutObjectACL
Return / accept String instead of a POJO. We need to use JAX-B
annotations instead of Jackson annotations because AWS decided to use
xsi:type annotations in the XML representation, which are not supported
by Jackson. It doesn't seem to be possible to use bot JAX-B and Jackson
for (de-)serialization in parallel.

fixes #213 / #290
@afranken afranken merged commit 7e9a74f into main Sep 26, 2022
@afranken afranken deleted the add-acl-handling branch September 26, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get ACL for new object S3Mock overwrites file data with ACL XML on 'putObject'
1 participant