Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed position of show more/less button #138

Closed
wants to merge 1 commit into from
Closed

fixed position of show more/less button #138

wants to merge 1 commit into from

Conversation

charan-mudiraj
Copy link

Description

The position property "Show More..." / "Show Less..." button was changing to "fixed" when "Show More..." button is clicked(when the repos list is expanded). This behaviour was implemented by using "showMore" boolean variable. In the fix, i've removed the usages of the "showMore" variable and permanently assigned the position as "absolute".

Related Issue

Fixes #51

Motivation and Context

The Button was overlapping with the content on its back. This fix resolves that issue by fixing the button at the bottom of the list irrespective of the state of "repos" list (expanded/collapsed).

How Has This Been Tested?

I've tested this fix by running it on my local environment. This change does not affecting any other areas of the code(since the usage of "showMore" boolean was limited to the button.

Screenshots (if appropriate):

Recording.2023-10-29.015304.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@charan-mudiraj
Copy link
Author

i'm unable to resolve the CLI Signing issue. i've already signed but still getting the issue. Please review my pull request.

@charan-mudiraj charan-mudiraj closed this by deleting the head repository Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Less button overlaps and flies in the middle of the screen blocking content
1 participant