Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rum): do not send top checkpoint twice #139

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix(rum): do not send top checkpoint twice #139

merged 1 commit into from
Oct 25, 2022

Conversation

trieloff
Copy link
Contributor

@trieloff trieloff commented Oct 24, 2022

Test URLs:

In the before setup, the top checkpoint would be sent twice, once from top and once from lazy

Before:
Screen Shot 2022-10-24 at 15 49 00

  1. top
  2. load
  3. lazy
  4. top (again?)
  5. favicon

After:

Screen Shot 2022-10-24 at 15 49 25

  1. top
  2. load
  3. lazy
  4. favicon
  5. viewmedia

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 24, 2022

Page Score PSI Audit Google
/?rum=on SI FCP LCP TBT CLS PSI

@trieloff trieloff merged commit 9383a77 into main Oct 25, 2022
@trieloff trieloff deleted the no-double-top branch October 25, 2022 19:24
ramboz added a commit that referenced this pull request Oct 26, 2022
ramboz added a commit to ramboz/aem-boilerplate that referenced this pull request Nov 4, 2022
omprakashgupta1995 referenced this pull request in WWWPiramalFinanceCOM/piramalfinance Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants