You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most customers directly use svg icons as they were explored by their preferred application (Illustrator, etc.), and that markup isn't compatible with the spriting logic in most cases. On top of that, the current spriting implementation has required frequent patching and isn't likely that stable yet. As such, we want to revert to basic icons decoration by default, and move the spriting to the block party instead until it is considered mature enough.
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
We are currently exploding lib-franklin into its own library which includes adding tests... I think this refactor would be a perfect fit to add the corresponding tests to the method - See https://github.com/adobe/aem-lib/blob/main/src/decorate.js#L51. Maybe the PR should be moved there.
@ramboz [https://github.com/adobe/aem-lib is ready (only need to adjust the documentation before release). Could you move your current work in this repo ? We will be able to write corresponding tests to all the icons handling edge cases ;)
ramboz
changed the title
fix: adjust icon spriting logic
fix: revert to simple icons decoration and extract the spriting logic
Sep 15, 2023
i think it would be great to also merge the PR here... i am when we are going to switch over to aem-lib codebase and i just wanted to update the documentation ahead of time...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ramboz
changed the title
Most customers directly use svg icons as they were explored by their preferred application (Illustrator, etc.), and that markup isn't compatible with the spriting logic in most cases. On top of that, the current spriting implementation has required frequent patching and isn't likely that stable yet. As such, we want to revert to basic icons decoration by default, and move the spriting to the block party instead until it is considered mature enough.
Test URLs: