chore: add fragments and use in header / footer #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
davidnuescheler
requested review from
fkakatie and
rofe
and removed request for
fkakatie
|
|
synox
reviewed
Sep 29, 2023
rofe
approved these changes
Oct 2, 2023
Co-authored-by: Raphael Wegmueller <github@rofe.com>
Co-authored-by: Raphael Wegmueller <github@rofe.com>
|
|
fkakatie
reviewed
Nov 1, 2023
fkakatie
approved these changes
Nov 1, 2023
|
|
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
arumsey
reviewed
Jan 12, 2024
| const footerPath = cfg.footer || '/footer'; | ||
| const resp = await fetch(`${footerPath}.plain.html`, window.location.pathname.endsWith('/footer') ? { cache: 'reload' } : {}); | ||
| // load footer fragment | ||
| const footerPath = footerMeta.footer || '/footer'; |
There was a problem hiding this comment.
@davidnuescheler I think this line should just be
const footerPath = footerMeta || '/footer';
since switching to getMetadata instead of readBlockConfig. IIUC, getMetadata only returns a string so footerMeta.footer will always be undefined.
Is my assumption correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting the move of fragments to boilerplate and using fragments to load header and footer.
Before:
https://main--aem-boilerplate--adobe.hlx.live/
https://main--aem-boilerplate--adobe.hlx.live/drafts/uncled/fragment-test
After:
https://fragments--aem-boilerplate--adobe.hlx.live/
https://fragments--aem-boilerplate--adobe.hlx.live/drafts/uncled/fragment-test